Skip to content

Fix nested super type modifier handling #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix nested super type modifier handling #705

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5238291
range fix
Aug 26, 2024
53e65b4
oh boy
Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/postgrex/extensions/multirange.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ defmodule Postgrex.Extensions.Multirange do
type =
case type do
{extension, sub_oids, sub_types} -> {extension, sub_oids, sub_types, nil}
{extension, _} -> {extension, nil}
extension -> {extension, nil}
end

Expand Down
1 change: 1 addition & 0 deletions lib/postgrex/extensions/range.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ defmodule Postgrex.Extensions.Range do
type =
case type do
{extension, sub_oids, sub_types} -> {extension, sub_oids, sub_types, nil}
{extension, _} -> {extension, nil}
extension -> {extension, nil}
end

Expand Down
6 changes: 6 additions & 0 deletions test/calendar_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ defmodule CalendarTest do
test "decode time with precision", context do
assert [[~T[00:00:00.000]]] = query("SELECT time(3) '00:00:00'", [])
assert [[[~T[00:00:00.000]]]] = query("SELECT ARRAY[time(3) '00:00:00']", [])

assert [[[[~T[00:00:00.000], ~T[00:00:00.000]], [~T[01:00:00.000], ~T[01:00:00.000]]]]] =
query(
"SELECT ARRAY[ARRAY[time(3) '00:00:00', time(3) '00:00:00'], ARRAY[time(3) '01:00:00', time(3) '01:00:00']]",
[]
)
end

test "decode timetz", context do
Expand Down
21 changes: 21 additions & 0 deletions test/query_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,27 @@ defmodule QueryTest do
}
]
] = query("SELECT '[2014-1-1,2014-12-31)'::tsrange", [])

assert [
[
[
%Postgrex.Range{
lower: ~N[2014-01-01 00:00:00.000000],
upper: ~N[2014-12-31 00:00:00.000000],
lower_inclusive: true,
upper_inclusive: false
},
%Postgrex.Range{
lower: ~N[2014-01-01 00:00:00.000000],
upper: ~N[2014-12-31 00:00:00.000000],
lower_inclusive: true,
upper_inclusive: false
}
]
]
]

query("SELECT ARRAY['[2014-1-1,2014-12-31)'::tsrange, '[2014-1-1,2014-12-31)'::tsrange]", [])
end

@tag min_pg_version: "14.0"
Expand Down