Prepare for release #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasanbal
approved these changes
Feb 20, 2025
jace1970
pushed a commit
to jace1970/lighter-python
that referenced
this pull request
Oct 23, 2025
…0-prefix quantity adjustment PROBLEM: Position sizing completely broken after incorrect "fixes": - XRP: $7026 instead of $10 (700x too large!) - BNB/LINK/DOGE/PUMP: $1000 instead of $10 (100x) - 1000BONK: $1500 instead of $10 (150x) ROOT CAUSE elliottech#1: My previous decimal "fixes" were WRONG - Changed BNBUSDC decimals 4→2 (WRONG! Should be 4) - Changed LINKUSDC decimals 3→1 (WRONG! Should be 3) - Changed PUMPUSDC decimals 2→0 (WRONG! Should be 2) - The ORIGINAL example config had CORRECT decimals all along! ROOT CAUSE elliottech#2: 1000-prefix markets need quantity adjustment - Taapi returns price for 1 BONK token ($0.00001) - Bot calculates: $10 / $0.00001 = 1,000,000 BONK - But Lighter's "1000BONK" market expects qty in "1000-BONK units" - 1 unit = 1000 tokens - Need to send: 1,000,000 / 1000 = 1,000 units (not 1,000,000) SOLUTION: 1. Reverted base_decimals back to original example values: - BNBUSDC: 2 → 4 ✓ - LINKUSDC: 1 → 3 ✓ - PUMPUSDC: 0 → 2 ✓ - DOGEUSDC: Already correct at 2 ✓ 2. Removed incorrect price adjustment code 3. Added quantity adjustment for 1000-prefix markets: - Divides calculated quantity by 1000 before sending to Lighter - Applies to: 1000PEPE, 1000SHIB, 1000BONK, 1000FLOKI All positions should now be $10 as intended. Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.