Skip to content

Conversation

@Bodo171
Copy link
Collaborator

@Bodo171 Bodo171 commented Feb 20, 2025

No description provided.

@Bodo171 Bodo171 changed the title Attempt fix actions Actions fix Feb 20, 2025
@Bodo171 Bodo171 force-pushed the attempt-fix-actions branch from 6eeec31 to e185081 Compare February 20, 2025 19:53
correct glob

str

change paths

rm 3.7

reqs

change support v

add eth-account

ignore apis

rm from travis

ignore-glob

flag
@Bodo171 Bodo171 force-pushed the attempt-fix-actions branch from e889768 to b7f4bfa Compare February 20, 2025 21:11
@Bodo171 Bodo171 marked this pull request as ready for review February 20, 2025 21:13
@Bodo171 Bodo171 merged commit a47b200 into main Feb 20, 2025
8 checks passed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file, the test step has a small issue. The run block for pytest contains two separate commands, which will cause the entire test suite to run twice.

The first pytest command should be removed, leaving only the one with the --ignore-glob flag.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The eth-account package is missing from this file. It was added to pyproject.toml but not here.

This inconsistency can cause installation errors for environments that rely on requirements.txt. Please add the package to this file as well to keep the dependencies in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants