Skip to content

Conversation

@Bvvvp009
Copy link
Contributor

@Bvvvp009 Bvvvp009 commented Oct 8, 2025

Adds native Windows (x86_64) support to the Lighter Python SDK.

Changes

  • Added Windows native signer (signer-amd64.dll)
  • Updated platform detection in signer_client.py
  • Updated documentation with build instructions
  • Enhanced .gitignore security

Platform Support

Linux x86_64 | macOS ARM64 | Windows x86_64

Binary Verification

SHA256: 2d7ce108ca85902119644d4cd79151814395990d96f635cb266b180dc8cb1fd3
Source: elliottech/lighter-go@72f51c3
Build: just prepare-windows-local

Testing

Tested on Windows 11 x86_64 - all features working

Notes

  • No breaking changes
  • Minimal code changes
  • Binary verifiable from public source

- Add Windows native signer binary (signer-amd64.dll)
- Update signer_client.py to detect and load Windows DLL
- Update documentation with Windows build instructions
- Add .env files to .gitignore for better security

Binary Verification:
SHA256: 2d7ce108ca85902119644d4cd79151814395990d96f635cb266b180dc8cb1fd3
Source: elliottech/lighter-go@72f51c3
Build: just prepare-windows-local

Tested on Windows 11 x86_64 - all features working
@alexvelea
Copy link
Collaborator

I (or someone else) will take a look. @Bvvvp009
Thanks for all the contributions <3
We'll review the lighter-go one first.

path_to_signer_folders = os.path.join(current_file_directory, "signers")

if is_arm and is_mac:
logging.debug("Detected ARM architecture on macOS.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the debug logs, and also add one for Win as well?
I merged something about logs which we handled incorrectly in #53 and I think they should be fineish now; they help when people are having issues but IDK. I can go either way.

@Bvvvp009
Copy link
Contributor Author

Thanks for the review, I will check and correct them.

@alexvelea
Copy link
Collaborator

hey @Bvvvp009, apparently I can push things on your branch, which is nice.
I've fixed the README.
If you could check if you could cross compile the darwin (mac) one since I just have a mac.

@alexvelea
Copy link
Collaborator

So I've updated the signers as well. I've merged a change in lighter-go which is not reflected here yet.
Because of that, all signers are changed. They should be the same as the ones from #61 but that's not merged yet -- waiting for review.

on your PR

velea:lighter/signers (windows-native-support-clean) $ git remote -v
origin  [email protected]:Bvvvp009/lighter-python.git (fetch)
origin  [email protected]:Bvvvp009/lighter-python.git (push)
velea:lighter/signers (windows-native-support-clean) $ md5 signer-*
MD5 (signer-amd64.dll) = ede210d06f236a378f6a08e9697d3fdb
MD5 (signer-amd64.so) = 352bcfa5eb64af6326e1522fbdd537c1
MD5 (signer-arm64.dylib) = 25a9b183140211a53d06cabec8d7cee7

on the #61 PR

velea:lighter/signers (devin/1760336303-read-only-auth) $ git remote -v
origin  [email protected]:elliottech/lighter-python.git (fetch)
origin  [email protected]:elliottech/lighter-python.git (push)
velea:lighter/signers (devin/1760336303-read-only-auth) $ md5 signer-*
MD5 (signer-amd64.so) = 352bcfa5eb64af6326e1522fbdd537c1
MD5 (signer-arm64.dylib) = 25a9b183140211a53d06cabec8d7cee7

@alexvelea alexvelea merged commit e6ffccb into elliottech:main Oct 13, 2025
4 checks passed
@alexvelea
Copy link
Collaborator

I've merged this @Bvvvp009
The only thing left is the darwin cross compile.
This looks good now.
Thanks a lot for all the good work.
If you manage to cross compile darwin we can create a new PR for that, to update the docs here and add the justfile.

@Bvvvp009
Copy link
Contributor Author

Thanks for the merge <3, I will try to add the cross compile for darwin as well.

@Bvvvp009 Bvvvp009 deleted the windows-native-support-clean branch November 21, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants