-
Notifications
You must be signed in to change notification settings - Fork 141
feat: Add native Windows (x86_64) support #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add native Windows (x86_64) support #59
Conversation
- Add Windows native signer binary (signer-amd64.dll) - Update signer_client.py to detect and load Windows DLL - Update documentation with Windows build instructions - Add .env files to .gitignore for better security Binary Verification: SHA256: 2d7ce108ca85902119644d4cd79151814395990d96f635cb266b180dc8cb1fd3 Source: elliottech/lighter-go@72f51c3 Build: just prepare-windows-local Tested on Windows 11 x86_64 - all features working
|
I (or someone else) will take a look. @Bvvvp009 |
| path_to_signer_folders = os.path.join(current_file_directory, "signers") | ||
|
|
||
| if is_arm and is_mac: | ||
| logging.debug("Detected ARM architecture on macOS.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the debug logs, and also add one for Win as well?
I merged something about logs which we handled incorrectly in #53 and I think they should be fineish now; they help when people are having issues but IDK. I can go either way.
|
Thanks for the review, I will check and correct them. |
|
hey @Bvvvp009, apparently I can push things on your branch, which is nice. |
|
So I've updated the signers as well. I've merged a change in on your PRon the #61 PR |
|
I've merged this @Bvvvp009 |
|
Thanks for the merge <3, I will try to add the cross compile for darwin as well. |
Adds native Windows (x86_64) support to the Lighter Python SDK.
Changes
signer-amd64.dll)signer_client.py.gitignoresecurityPlatform Support
Linux x86_64 | macOS ARM64 | Windows x86_64 ✅
Binary Verification
SHA256:
2d7ce108ca85902119644d4cd79151814395990d96f635cb266b180dc8cb1fd3Source: elliottech/lighter-go@72f51c3
Build:
just prepare-windows-localTesting
Tested on Windows 11 x86_64 - all features working
Notes