Make String.toTitleCase work with non-english alphabets#36
Open
Herteby wants to merge 1 commit intoelm-community:masterfrom
Open
Make String.toTitleCase work with non-english alphabets#36Herteby wants to merge 1 commit intoelm-community:masterfrom
Herteby wants to merge 1 commit intoelm-community:masterfrom
Conversation
The behavior might slightly differ from the original in cases where there's a special character in front of a word. It's a lot simpler though!
Author
|
Here's an alternative version which more closely follows the original: |
Author
|
Or a third option: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior might slightly differ from the original in cases where there's a special character in front of a word. It's a lot simpler though!
The original has two issues:
[a-z]only matches precisely a - z, and\wonly matches english word characters.