Replace RegEx with version compliant with broader RegEx parsers#47
Open
dwayne-mss wants to merge 1 commit intoelm-community:masterfrom
Open
Replace RegEx with version compliant with broader RegEx parsers#47dwayne-mss wants to merge 1 commit intoelm-community:masterfrom
dwayne-mss wants to merge 1 commit intoelm-community:masterfrom
Conversation
ahankinson
added a commit
to ahankinson/core-extra
that referenced
this pull request
Sep 4, 2023
An unescaped dash can be misinterpreted in JavaScript, so it is escaped. This is a follow-on from elm-community/string-extra#47, but the method of fixing it is to explicitly escape the dash, rather than moving its position.
gampleman
pushed a commit
to elmcraft/core-extra
that referenced
this pull request
Sep 4, 2023
An unescaped dash can be misinterpreted in JavaScript, so it is escaped. This is a follow-on from elm-community/string-extra#47, but the method of fixing it is to explicitly escape the dash, rather than moving its position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RegEx expression
[_-\\s]+is invalid in many RegEx parsers... and scripts created by Elm will fail when this JS method is run within those environments.This PR replaces the above expression with
[_\\s-]+which I believe has the same effect, but does not result in the invalid character range error.I would also like to back port this to version 1.5.0 if approved.