Improve performance for rightOfBack and leftOfBack#51
Open
jfmengels wants to merge 2 commits intoelm-community:masterfrom
Open
Improve performance for rightOfBack and leftOfBack#51jfmengels wants to merge 2 commits intoelm-community:masterfrom
jfmengels wants to merge 2 commits intoelm-community:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a quick look at whether there were functions with "obvious" performance improvements, and came across
rightOfBack(theList.reverse+List.headcalled out to me).I tried several approaches (that you can go through in this benchmark). The final benchmark gives the following:
leftOfBackhad a very similar algorithm, so I updated it as well to use the same improvements, with the following results (benchmark)Less impressive, but still a nice improvement.
There were no tests for these 2 functions, so I added basic ones, based on the examples.