fix: variable-sized bounding boxes #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even monospace fonts can have variable sized BBX fields. For characters with no data such as SPACE, the BBX can be 1x1. If space is the first character in the font, this leads to the converted font having all characters be 1x1 pixel. To resolve the issue, use the FONTBOUNDINGBOX field for the bounding box instead of the BBX of the first character when converting.
Contributor
Author
|
With this fix in place, I'm able to generate bdf fonts using FontForge (following directions from adafruit), then convert them successfully for embedded graphics. |
Member
|
This seems like the right way to handle this, but I can't remember if there was a reason not to trust |
rfuest
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even monospace fonts can have variable sized BBX fields. For characters with no data such as SPACE, the BBX can be 1x1. If space is the first character in the font, this leads to the converted font having all characters be 1x1 pixel.
To resolve the issue, use the FONTBOUNDINGBOX field for the bounding box instead of the BBX of the first character when converting.