fix: AttributeError in ColPaliEngineWrapper similarity method #3177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 😁
I'm using
ColPali
models to evaluate ViDoRe benchmarks and encountered anAttributeError
. The issue occurs becauseColPaliEngineWrapper.similarity()
tries to useself.processor_kwargs
, which is not defined in the class. I've temporarily resolved this by removing the**self.processor_kwargs
reference.This issue likely stems from this discussion.
The ColPali Engine's score_multi_vector method can accept optional arguments like
batch_size
anddevice
. However, should we allow passing these parameters for the similarity scoring method at theColPaliEngineWrapper
level? I believe this is conceptually different from the batch size and device used for embedding generation. So I'm not sure where these arguments should be received and passed through. Any ideas or suggestions would be welcome!Thanks!!