Skip to content

Set type=module in package.json #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Set type=module in package.json #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
66e4504
Set type=module in package.json
NullVoxPopuli May 20, 2025
94872e6
Fix file extensions
NullVoxPopuli May 20, 2025
49e8c79
Rename config files to cjs and update eslint so that cjs means node
NullVoxPopuli May 20, 2025
dd02f7b
Update our own eslint config
NullVoxPopuli May 20, 2025
1836970
Update testem-proxy to cjs
NullVoxPopuli May 20, 2025
fdc27c4
Update references in tests of testem*.js to testem*.cjs
NullVoxPopuli May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,20 @@ export default [
},
},
},
{
files: ['**/*.cjs'],
languageOptions: {
sourceType: 'script',
},
},
{ languageOptions: { globals: globals.node } },
pluginJs.configs.recommended,
eslintConfigPrettier,
{
ignores: ['tests/fixture/*', 'tests/fixture-ts/*', 'files/ember-cli-build.js'],
ignores: [
'tests/fixture/*',
'tests/fixture-ts/*',
'files/ember-cli-build.cjs',
],
},
];
0 files/.prettierrc.js → files/.prettierrc.cjs
View file
Open in desktop
File renamed without changes.
0 files/.stylelintrc.js → files/.stylelintrc.cjs
View file
Open in desktop
File renamed without changes.
0 files/.template-lintrc.js → files/.template-lintrc.cjs
View file
Open in desktop
File renamed without changes.
11 changes: 1 addition & 10 deletions files/_js_eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,7 @@ export default [
* CJS node files
*/
{
files: [
'**/*.cjs',
'config/**/*.js',
'testem.js',
'testem*.js',
'.prettierrc.js',
'.stylelintrc.js',
'.template-lintrc.js',
'ember-cli-build.js',
],
files: ['**/*.cjs'],
plugins: {
n,
},
Expand Down
11 changes: 1 addition & 10 deletions files/_ts_eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,7 @@ export default ts.config(
* CJS node files
*/
{
files: [
'**/*.cjs',
'config/**/*.js',
'testem.js',
'testem*.js',
'.prettierrc.js',
'.stylelintrc.js',
'.template-lintrc.js',
'ember-cli-build.js',
],
files: ['**/*.cjs'],
plugins: {
n,
},
Expand Down
0 files/config/environment.js → files/config/environment.cjs
View file
Open in desktop
File renamed without changes.
0 files/config/targets.js → files/config/targets.cjs
View file
Open in desktop
File renamed without changes.
0 files/ember-cli-build.js → files/ember-cli-build.cjs
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions files/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"private": true,
"description": "Small description for <%= name %> goes here",
"repository": "",
"type": "module",
"license": "MIT",
"author": "",
"directories": {
Expand Down
6 changes: 3 additions & 3 deletions tests/default.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
});

writeFileSync(
join(project.dir(), 'testem-dev.js'),
join(project.dir(), 'testem-dev.cjs'),
`module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
Expand All @@ -115,16 +115,16 @@
},
},
middleware: [
require(__dirname + '/testem-proxy.js')('${appURL}')
require(__dirname + '/testem-proxy.cjs')('${appURL}')
],
};
`,
);

let testResult = await project.execa('pnpm', [

Check failure on line 124 in tests/default.test.mjs

View workflow job for this annotation

GitHub Actions / Test

tests/default.test.mjs > basic functionality > with flags: '--typescript' > successfully runs tests in dev mode 

ExecaError: Command failed with exit code 1: pnpm testem --file testem-dev.cjs ci

not ok 1 Chrome 136.0 - [undefined ms] - Global error: Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-64JGPULG.js?v=f7977edf, line 216
    ---
        browser log: |
            {"type":"error","text":"[vite] failed to connect to websocket.\nyour current setup:\n  (browser) localhost:7357/ <--[HTTP]--> localhost:4200/ (server)\n  (browser) localhost:7357/ <--[WebSocket (failing)]--> localhost:4200/ (server)\nCheck out your Vite / network configuration and https://vite.dev/config/server-options.html#server-hmr ."}
            {"type":"error","text":"Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-64JGPULG.js?v=f7977edf, line 216\n","testContext":{}}
    ...

1..1
# tests 1
# pass  0
# skip  0
# todo  0
# fail  1
 ❯ getFinalError node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/final-error.js:6:9
 ❯ makeError node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/result.js:108:16
 ❯ getAsyncResult node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:167:4
 ❯ handlePromise node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:150:17
 ❯ tests/default.test.mjs:124:28

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { shortMessage: 'Command failed with exit code 1: pnpm testem --file testem-dev.cjs ci', command: 'pnpm testem --file testem-dev.cjs ci', escapedCommand: 'pnpm testem --file testem-dev.cjs ci', cwd: '/tmp/tmp-2149-O56rFWPCfDgw/test-app', durationMs: 9742.458548, failed: true, timedOut: false, isCanceled: false, isGracefullyCanceled: false, isTerminated: false, isMaxBuffer: false, isForcefullyTerminated: false, exitCode: 1, stdout: 'not ok 1 Chrome 136.0 - [undefined ms] - Global error: Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-64JGPULG.js?v=f7977edf, line 216\n    ---\n        browser log: |\n            {"type":"error","text":"[vite] failed to connect to websocket.\nyour current setup:\n  (browser) localhost:7357/ <--[HTTP]--> localhost:4200/ (server)\n  (browser) localhost:7357/ <--[WebSocket (failing)]--> localhost:4200/ (server)\nCheck out your Vite / network configuration and https://vite.dev/config/server-options.html#server-hmr ."}\n            {"type":"error","text":"Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-64JGPULG.js?v=f7977edf, line 216\n","testContext":{}}\n    ...\n\n1..1\n# tests 1\n# pass  0\n# skip  0\n# todo  0\n# fail  1', stderr: '', stdio: [ undefined, 'not ok 1 Chrome 136.0 - [undefined ms] - Global error: Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-64JGPULG.js?v=f7977edf, line 216\n    ---\n        browser log: |\n            {"type":"error","text":"[vite] failed to connect to websocket.\nyour current setup:\n  (browser) localhost:7357/ <--[HTTP]--> localhost:4200/ (server)\n  (browser) localhost:7357/ <--[WebSocket (failing)]--> localhost:4200/ (server)\nCheck out your Vite / network configuration and https://vite.dev/config/server-options.html#server-hmr ."}\n            {"type":"error","text":"Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-64JGPULG.js?v=f7977edf, line 216\n","testContext":{}}\n    ...\n\n1..1\n# tests 1\n# pass  0\n# skip  0\n# todo  0\n# fail  1', '' ], ipcOutput: [], pipedFrom: [] }

Check failure on line 124 in tests/default.test.mjs

View workflow job for this annotation

GitHub Actions / Test

tests/default.test.mjs > basic functionality > with flags: '' > successfully runs tests in dev mode 

ExecaError: Command failed with exit code 1: pnpm testem --file testem-dev.cjs ci

not ok 1 Chrome 136.0 - [undefined ms] - Global error: Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-ZV3BZDQP.js?v=25feecad, line 216
    ---
        browser log: |
            {"type":"info","text":"[vite] Direct websocket connection fallback. Check out https://vite.dev/config/server-options.html#server-hmr to remove the previous connection error."}
            {"type":"error","text":"Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-ZV3BZDQP.js?v=25feecad, line 216\n","testContext":{}}
    ...

1..1
# tests 1
# pass  0
# skip  0
# todo  0
# fail  1
 ❯ getFinalError node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/final-error.js:6:9
 ❯ makeError node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/result.js:108:16
 ❯ getAsyncResult node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:167:4
 ❯ handlePromise node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:150:17
 ❯ tests/default.test.mjs:124:28

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { shortMessage: 'Command failed with exit code 1: pnpm testem --file testem-dev.cjs ci', command: 'pnpm testem --file testem-dev.cjs ci', escapedCommand: 'pnpm testem --file testem-dev.cjs ci', cwd: '/tmp/tmp-2149-FwVNEBdZrEho/test-app', durationMs: 9219.869015, failed: true, timedOut: false, isCanceled: false, isGracefullyCanceled: false, isTerminated: false, isMaxBuffer: false, isForcefullyTerminated: false, exitCode: 1, stdout: 'not ok 1 Chrome 136.0 - [undefined ms] - Global error: Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-ZV3BZDQP.js?v=25feecad, line 216\n    ---\n        browser log: |\n            {"type":"info","text":"[vite] Direct websocket connection fallback. Check out https://vite.dev/config/server-options.html#server-hmr to remove the previous connection error."}\n            {"type":"error","text":"Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-ZV3BZDQP.js?v=25feecad, line 216\n","testContext":{}}\n    ...\n\n1..1\n# tests 1\n# pass  0\n# skip  0\n# todo  0\n# fail  1', stderr: '', stdio: [ undefined, 'not ok 1 Chrome 136.0 - [undefined ms] - Global error: Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-ZV3BZDQP.js?v=25feecad, line 216\n    ---\n        browser log: |\n            {"type":"info","text":"[vite] Direct websocket connection fallback. Check out https://vite.dev/config/server-options.html#server-hmr to remove the previous connection error."}\n            {"type":"error","text":"Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-ZV3BZDQP.js?v=25feecad, line 216\n","testContext":{}}\n    ...\n\n1..1\n# tests 1\n# pass  0\n# skip  0\n# todo  0\n# fail  1', '' ], ipcOutput: [], pipedFrom: [] }
'testem',
'--file',
'testem-dev.js',
'testem-dev.cjs',
'ci',
]);
expect(testResult.exitCode).to.eq(0, testResult.output);
Expand Down
0 tests/fixture-ts/testem-proxy.js → tests/fixture-ts/testem-proxy.cjs
View file
Open in desktop
File renamed without changes.
0 tests/fixture/testem-proxy.js → tests/fixture/testem-proxy.cjs
View file
Open in desktop
File renamed without changes.
Loading