Simplify lint configs for our lack of ambiguous js extensions in node-land #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
declare-cjs
branch
from
2dd25ea to
dedb35b
Compare
NullVoxPopuli
changed the title
NullVoxPopuli
force-pushed
the
declare-cjs
branch
from
05be2ed to
0535d2f
Compare
NullVoxPopuli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this helps with compat in tooling as well as makes the transition to type=module easier.
Not all of the files are converted to .cjs (ember-cli-build, targets, environment) -- because something goes wrong when they become .cjs, and I want to save that debugging for another time, since we can land the other config files separately