-
-
Notifications
You must be signed in to change notification settings - Fork 4
Use a default lang to improve default a11y #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Would it make more sense to set a default here instead Would apply to all blueprints then. |
perhaps -- but then we need to wait 3 months for release |
oh, I thought release-plan was added to the repo to not need to do that no more. |
so... it's true that we can release easier now, but changing the default behaviour of something is a very very big thing to backport 🙈 that should follow the release train |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the right way to do this 🤔 I think we need to make sure that generating with --lang
works and we should then make it have a default in the index.js no? at least that way we can have a good way to add a help message that makes sense? correct me if I'm wrong
how do we adjust the help message for args we don't control? is there a way to move all that stuff out of ember-cli? |
I'm working on it ;) |
No default was decided in https://rfcs.emberjs.com/id/0635-ember-new-lang/ |
Considering this a bugfix, because every app needs a
lang
according to every html validator