Skip to content

Conversation

NullVoxPopuli
Copy link
Contributor

Considering this a bugfix, because every app needs a lang according to every html validator

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Jun 21, 2025
@evoactivity
Copy link
Contributor

Would it make more sense to set a default here instead
https://github.com/ember-cli/ember-cli/blob/3682b6e6192f9a1e0348b5a1bacf003e1565eec7/lib/commands/init.js#L38C1-L41C7

Would apply to all blueprints then.

@NullVoxPopuli
Copy link
Contributor Author

perhaps -- but then we need to wait 3 months for release

@evoactivity
Copy link
Contributor

oh, I thought release-plan was added to the repo to not need to do that no more.

@mansona
Copy link
Member

mansona commented Jun 25, 2025

oh, I thought release-plan was added to the repo to not need to do that no more.

so... it's true that we can release easier now, but changing the default behaviour of something is a very very big thing to backport 🙈 that should follow the release train

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right way to do this 🤔 I think we need to make sure that generating with --lang works and we should then make it have a default in the index.js no? at least that way we can have a good way to add a help message that makes sense? correct me if I'm wrong

@NullVoxPopuli
Copy link
Contributor Author

at least that way we can have a good way to add a help message that makes sense? correct me if I'm wrong

how do we adjust the help message for args we don't control?

is there a way to move all that stuff out of ember-cli?

@mansona
Copy link
Member

mansona commented Jun 25, 2025

is there a way to move all that stuff out of ember-cli?

I'm working on it ;)

@kategengler
Copy link
Member

No default was decided in https://rfcs.emberjs.com/id/0635-ember-new-lang/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants