Skip to content

Update babel-plugin-ember-template-compilation #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Update babel-plugin-ember-template-compilation #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0f70497
Update babel-plugin-ember-template-compilation
NullVoxPopuli May 7, 2025
52313d7
Update bable config
NullVoxPopuli May 7, 2025
1b6838b
--experimental-require-module
NullVoxPopuli May 20, 2025
d3fbd6d
Node doesn't allow --experimental-require-module in NODE_OPTIONS
NullVoxPopuli May 20, 2025
7b94881
Fix test command
NullVoxPopuli May 20, 2025
1410797
We can't support node 18
NullVoxPopuli May 20, 2025
0afe669
Is node22 compat with the ESM version of this plugin?
NullVoxPopuli May 20, 2025
3fe61cd
Rename testem-proxy.js to testem-proxy.cjs so that eslint chooses the…
NullVoxPopuli May 29, 2025
5f191cf
Eliminate more ambiguous file extensions by renaming cjs files to hav…
NullVoxPopuli May 29, 2025
e86ae0c
Eliminate more ambiguous file extensions by renaming cjs files to hav…
NullVoxPopuli May 29, 2025
9cd3d86
ope
NullVoxPopuli May 29, 2025
3f28ebf
Update lints
NullVoxPopuli May 29, 2025
b90666d
Bump min @babel/eslint-parser
NullVoxPopuli Jun 3, 2025
08ee872
Use the experimental worker
NullVoxPopuli Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: pnpm
- run: pnpm install --frozen-lockfile
- run: pnpm lint
Expand All @@ -29,7 +29,7 @@ jobs:
- uses: pnpm/action-setup@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 22
cache: pnpm
- run: pnpm install --frozen-lockfile
- run: pnpm test
4 changes: 2 additions & 2 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import eslintConfigPrettier from 'eslint-config-prettier';

export default [
{
files: ['**/*.js'],
files: ['**/*.js', '**/*.cjs'],
languageOptions: { sourceType: 'commonjs' },
},
{
Expand All @@ -25,6 +25,6 @@ export default [
pluginJs.configs.recommended,
eslintConfigPrettier,
{
ignores: ['tests/fixture/*', 'tests/fixture-ts/*', 'files/ember-cli-build.js'],
ignores: ['tests/fixture/*', 'tests/fixture-ts/*', 'files/ember-cli-build.cjs'],
},
];
0 files/.prettierrc.js → files/.prettierrc.cjs
View file
Open in desktop
File renamed without changes.
0 files/.stylelintrc.js → files/.stylelintrc.cjs
View file
Open in desktop
File renamed without changes.
0 files/.template-lintrc.js → files/.template-lintrc.cjs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion files/_js_babel.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const {
module.exports = {
plugins: [
[
'babel-plugin-ember-template-compilation',
'module:babel-plugin-ember-template-compilation',
{
compilerPath: 'ember-source/dist/ember-template-compiler.js',
enableLegacyModules: [
Expand Down
2 changes: 1 addition & 1 deletion files/_js_eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import eslintConfigPrettier from 'eslint-config-prettier';
import qunit from 'eslint-plugin-qunit';
import n from 'eslint-plugin-n';

import babelParser from '@babel/eslint-parser';
import babelParser from '@babel/eslint-parser/experimental-worker';

const esmParserOptions = {
ecmaFeatures: { modules: true },
Expand Down
2 changes: 1 addition & 1 deletion files/_ts_babel.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = {
},
],
[
'babel-plugin-ember-template-compilation',
'module:babel-plugin-ember-template-compilation',
{
compilerPath: 'ember-source/dist/ember-template-compiler.js',
enableLegacyModules: [
Expand Down
2 changes: 1 addition & 1 deletion files/_ts_eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import eslintConfigPrettier from 'eslint-config-prettier';
import qunit from 'eslint-plugin-qunit';
import n from 'eslint-plugin-n';

import babelParser from '@babel/eslint-parser';
import babelParser from '@babel/eslint-parser/experimental-worker';

const parserOptions = {
esm: {
Expand Down
0 files/config/environment.js → files/config/environment.cjs
View file
Open in desktop
File renamed without changes.
0 files/config/targets.js → files/config/targets.cjs
View file
Open in desktop
File renamed without changes.
0 files/ember-cli-build.js → files/ember-cli-build.cjs
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions files/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@babel/runtime": "^7.27.1",
"@babel/plugin-transform-runtime": "^7.27.1<% if (typescript) { %>",
"@babel/plugin-transform-typescript": "^7.27.1<% } %>",
"@babel/eslint-parser": "^7.27.1<% if (typescript && emberData) { %>",
"@babel/eslint-parser": "^7.27.5<% if (typescript && emberData) { %>",
"@ember-data/adapter": "~5.5.0",
"@ember-data/graph": "~5.5.0",
"@ember-data/json-api": "~5.5.0",
Expand Down Expand Up @@ -68,7 +68,7 @@
"@types/rsvp": "^4.0.9<% if (emberData) {%>",
"@warp-drive/core-types": "~5.5.0<% }} %><% if (emberData) { %>",
"@warp-drive/ember": "~5.5.0<% } %>",
"babel-plugin-ember-template-compilation": "^2.4.1",
"babel-plugin-ember-template-compilation": "^3.0.0",
"concurrently": "^9.1.2",
"decorator-transforms": "^2.3.0",
"ember-auto-import": "^2.10.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/default.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,13 @@
},
},
middleware: [
require(__dirname + '/testem-proxy.js')('${appURL}')
require(__dirname + '/testem-proxy.cjs')('${appURL}')
],
};
`,
);

let testResult = await project.execa('pnpm', [

Check failure on line 140 in tests/default.test.mjs

View workflow job for this annotation

GitHub Actions / Test

tests/default.test.mjs > basic functionality > typescript > successfully runs tests in dev mode 

ExecaError: Command failed with exit code 1: pnpm testem --file testem-dev.js ci

(node:3725) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

not ok 1 Chrome 137.0 - [undefined ms] - Global error: Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-UOKJQGUC.js?v=f51c1e62, line 214
    ---
        browser log: |
            {"type":"info","text":"[vite] Direct websocket connection fallback. Check out https://vite.dev/config/server-options.html#server-hmr to remove the previous connection error."}
            {"type":"error","text":"Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-UOKJQGUC.js?v=f51c1e62, line 214\n","testContext":{}}
    ...

1..1
# tests 1
# pass  0
# skip  0
# todo  0
# fail  1
 ❯ getFinalError node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/final-error.js:6:9
 ❯ makeError node_modules/.pnpm/[email protected]/node_modules/execa/lib/return/result.js:108:16
 ❯ getAsyncResult node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:167:4
 ❯ handlePromise node_modules/.pnpm/[email protected]/node_modules/execa/lib/methods/main-async.js:150:17
 ❯ tests/default.test.mjs:140:28

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { shortMessage: 'Command failed with exit code 1: pnpm testem --file testem-dev.js ci', command: 'pnpm testem --file testem-dev.js ci', escapedCommand: 'pnpm testem --file testem-dev.js ci', cwd: '/tmp/tmp-2111-ZiBZLcOeCB73/test-app', durationMs: 8928.56159, failed: true, timedOut: false, isCanceled: false, isGracefullyCanceled: false, isTerminated: false, isMaxBuffer: false, isForcefullyTerminated: false, exitCode: 1, stdout: 'not ok 1 Chrome 137.0 - [undefined ms] - Global error: Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-UOKJQGUC.js?v=f51c1e62, line 214\n    ---\n        browser log: |\n            {"type":"info","text":"[vite] Direct websocket connection fallback. Check out https://vite.dev/config/server-options.html#server-hmr to remove the previous connection error."}\n            {"type":"error","text":"Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-UOKJQGUC.js?v=f51c1e62, line 214\n","testContext":{}}\n    ...\n\n1..1\n# tests 1\n# pass  0\n# skip  0\n# todo  0\n# fail  1', stderr: '(node:3725) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.\n(Use `node --trace-deprecation ...` to show where the warning was created)', stdio: [ undefined, 'not ok 1 Chrome 137.0 - [undefined ms] - Global error: Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-UOKJQGUC.js?v=f51c1e62, line 214\n    ---\n        browser log: |\n            {"type":"info","text":"[vite] Direct websocket connection fallback. Check out https://vite.dev/config/server-options.html#server-hmr to remove the previous connection error."}\n            {"type":"error","text":"Uncaught Error: Assertion Failed: config is not an object at http://localhost:7357/node_modules/.vite/deps/chunk-UOKJQGUC.js?v=f51c1e62, line 214\n","testContext":{}}\n    ...\n\n1..1\n# tests 1\n# pass  0\n# skip  0\n# todo  0\n# fail  1', '(node:3725) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.\n(Use `node --trace-deprecation ...` to show where the warning was created)' ], ipcOutput: [], pipedFrom: [] }
'testem',
'--file',
'testem-dev.js',
Expand Down
0 tests/fixture-ts/testem-proxy.js → tests/fixture-ts/testem-proxy.cjs
View file
Open in desktop
File renamed without changes.
0 tests/fixture/testem-proxy.js → tests/fixture/testem-proxy.cjs
View file
Open in desktop
File renamed without changes.
Loading