Skip to content

Conversation

@mariokostelac
Copy link
Contributor

This is an example of how we could support per-test test splitting for
qunit. I would like to get feedback on the approach and whether it has
some future so I could continue working on it.
It breaks mocha so I am interested in thoughts on that as well.

Tests failing: unit tests of TestLoader.

This is an example of how we could support per-test test splitting for
qunit. I would like to get feedback on the approach and whether it has
some future so I could continue working on it.
It breaks mocha so I am interested in thoughts on that as well.
@mariokostelac
Copy link
Contributor Author

Just to note, I am willing to work on getting it done for Mocha as well if this approach is ok with you.

Copy link
Member

@trentmwillis trentmwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I won’t be able to get to this this week due to travel, but definitely want to review when I get back. This would be an awesome feature to have!

@mariokostelac
Copy link
Contributor Author

No problem, thanks for taking time to comment :). Looking forward to make it work for everybody.

Copy link
Member

@trentmwillis trentmwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, seems like a reasonable approach. However, I'd like to ensure we maintain support for both QUnit and Mocha and the current implementation looks pretty tightly coupled to QUnit. So, there will likely need to be some sort of framework detection.

If you can get the tests passing, I'll do a more thorough review.

@mariokostelac
Copy link
Contributor Author

I will try to get them passing next week. It is possible I will need a little bit of help. If that happens, will communicate through comments here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants