Skip to content

Conversation

MinThaMie
Copy link
Contributor

Reverts #263

As @kategengler mentioned I was a bit too eager and should have merged this after all the work is done to make strict default

This reverts commit cba238c.
@MinThaMie MinThaMie self-assigned this Sep 9, 2025
@MinThaMie MinThaMie merged commit 2de2e7d into main Sep 9, 2025
5 checks passed
@MinThaMie MinThaMie deleted the revert-263-strict branch September 9, 2025 15:39
@tcjr
Copy link
Contributor

tcjr commented Sep 9, 2025

Reverts #263

As @kategengler mentioned I was a bit too eager and should have merged this after all the work is done to make strict default

Since all this code works today, I don't see the harm.

@kategengler
Copy link
Contributor

The tutorial was broken for awhile and not building. I'd like to see one last version with the classic tutorial up-to-date. In 6.8 we expect --strict to be the default and the rest of our guides to be updated as well. It would also be an odd experience to see the tutorial show one type of components and then the rest of the docs not be updated.

@tcjr
Copy link
Contributor

tcjr commented Sep 10, 2025

It's probably good you reverted this since it's only the authoring format changes and if you are waiting until it's switched on by default (in Ember 6.8), then it won't work anyway.

Super Rentals won't work with Vite without changing a few things. I liked the idea of knocking out the authoring format changes first then dealing with the necessary Vite changes.

I took some notes on what I think will likely have to change, so I can pass those onto whomever updates SuperRentals to work with Vite.

mansona added a commit that referenced this pull request Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants