Replace map box with TomTom #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
approved these changes
Sep 27, 2025
|
Just saw the notes on my original PR and how riddled with mistakes it was - oops! Thanks so much for this! |
Definitely not mistakes -- just a few missed spots. The nature of how this tutorial is structured makes it one of the trickiest to contribute to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on TeriyakiBomb's PR branch and fixes up all the code and non-code parts of Chapter 7 to get it working with TomTom. (I couldn't push to that fork.)
This addresses all of the comments I left on the original PR. It was mostly just a matter of fixing up the URL & params to use TomTom's API instead of the Mapbox API, then regenerating the component and test patches to reflect these changes.
IMPORTANT: To get CI working, somebody needs to put a TomTom key in the workflow build.yml file. The Mapbox key is hardcoded in the build.yml file, so it should just be a matter of replacing that with a TomTom key.