Fix Vite version of the tutorial #272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
approved these changes
Sep 29, 2025
kategengler
reviewed
Sep 29, 2025
kategengler
reviewed
Sep 29, 2025
kategengler
reviewed
Sep 29, 2025
| ``` | ||
|
|
||
| ```run:command hidden=true cwd=super-rentals | ||
| # hack until https://github.com/emberjs/ember.js/pull/20988 is fixed |
There was a problem hiding this comment.
While this will make the tutorial build, anybody following it will see an error and be blocked
There was a problem hiding this comment.
I'm assuming you're leaving this comment for anyone else reading along since we discussed this on discord 🤔
We're just waiting for the next beta with the backport of the linked PR to be released and I'll remove this line 👍
|
Welcome Page needs an update |
16 tasks
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like it's not going to be too difficult to fix 🎉
Found one blocker upstream so far: emberjs/ember.js#20988