Add a test that verifies @model is stable between route transitions#20959
Closed
Windvis wants to merge 4 commits intoemberjs:mainfrom
Closed
Add a test that verifies @model is stable between route transitions#20959Windvis wants to merge 4 commits intoemberjs:mainfrom
@model is stable between route transitions#20959Windvis wants to merge 4 commits intoemberjs:mainfrom
Conversation
This test doesn't actually reproduce the problem since a Glimmer component seems needed for that.
Contributor
Estimated Asset SizesDiff Details
|
c96149a to
e5ba618
Compare
90cddad to
2622225
Compare
We now import the `@glimmer/component` package in test files which requires it to be built before Vite runs.
Contributor
|
do you happen to know if this ever worked? |
Contributor
Author
I don't think so, no. As far as I know it has been an issue since It's just a tricky to reproduce issue so it seemed that it was "solved" at some point in time. |
johanrd
pushed a commit
to johanrd/ember.js
that referenced
this pull request
Mar 8, 2026
When transitioning between routes, the @model argument on a Glimmer component becomes unstable during willDestroy - the model value changes before the component is properly destroyed. Requires @glimmer/component Vite alias to resolve in tests. Based on PR emberjs#20959 by @Windvis.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a failing test for the issue mentioned in #18987 based on the StackBlitz reproduction and supersedes #19257.
I needed to do some changes to the Vite and CI setup to make the
@glimmer/componentimports working in the test files. Not sure if what I did is the best solution but it works for the reproduction at least.