Prod build + package.json#export condition for production#21113
Closed
NullVoxPopuli wants to merge 1 commit intonvp/no-more-macrosfrom
Closed
Prod build + package.json#export condition for production#21113NullVoxPopuli wants to merge 1 commit intonvp/no-more-macrosfrom
NullVoxPopuli wants to merge 1 commit intonvp/no-more-macrosfrom
Conversation
NullVoxPopuli
changed the title
Contributor
Estimated Asset SizesDiff --- main/out.txt 2026-02-17 19:37:18.000000000 +0000
+++ pr/./pr-22464603691/out.txt 2026-02-26 22:51:02.000000000 +0000
@@ -1,62 +1,62 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 351.99 KB │ 203.84 KB ║
+║ Total │ 323.31 KB │ 198.72 KB ║
╚═══════╧═══════════╧═══════════╝
╔══════════════════════╤═══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼───────────╢
-║ Total │ 313.39 KB │ 181.91 KB ║
+║ Total │ 265.33 KB │ 166.05 KB ║
╟──────────────────────┼───────────┼───────────╢
-║ -internals │ 36.65 KB │ 26.22 KB ║
-║ application │ 13.23 KB │ 8.05 KB ║
-║ array │ 13.01 KB │ 7.46 KB ║
-║ canary-features │ 304 B │ 389 B ║
-║ component │ 2.05 KB │ 1.64 KB ║
-║ controller │ 1.96 KB │ 1.41 KB ║
-║ debug │ 11.69 KB │ 8.12 KB ║
+║ -internals │ 56.9 KB │ 36.68 KB ║
+║ application │ 15.93 KB │ 9.17 KB ║
+║ array │ 15.18 KB │ 8.53 KB ║
+║ canary-features │ 298 B │ 386 B ║
+║ component │ 2.16 KB │ 1.63 KB ║
+║ controller │ 1.96 KB │ 1.47 KB ║
+║ debug │ 17.18 KB │ 11.43 KB ║
║ deprecated-features │ 31 B │ 77 B ║
║ destroyable │ 561 B │ 383 B ║
║ enumerable │ 259 B │ 387 B ║
-║ helper │ 1.08 KB │ 811 B ║
-║ instrumentation │ 2.43 KB │ 1.79 KB ║
-║ modifier │ 1.22 KB │ 965 B ║
-║ object │ 35.94 KB │ 22.16 KB ║
+║ helper │ 1.13 KB │ 838 B ║
+║ instrumentation │ 2.46 KB │ 1.77 KB ║
+║ modifier │ 1.29 KB │ 970 B ║
+║ object │ 51.62 KB │ 28.92 KB ║
║ owner │ 159 B │ 178 B ║
-║ renderer │ 630 B │ 487 B ║
-║ routing │ 59.3 KB │ 34.12 KB ║
-║ runloop │ 2.36 KB │ 1.5 KB ║
-║ service │ 1 KB │ 845 B ║
-║ template │ 654 B │ 541 B ║
-║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 123.08 KB │ 59.45 KB ║
-║ template-factory │ 370 B │ 374 B ║
+║ renderer │ 671 B │ 527 B ║
+║ routing │ 70.9 KB │ 40.58 KB ║
+║ runloop │ 2.7 KB │ 1.69 KB ║
+║ service │ 1 KB │ 863 B ║
+║ template │ 695 B │ 543 B ║
+║ template-compilation │ 640 B │ 540 B ║
+║ template-compiler │ 15.9 KB │ 13.71 KB ║
+║ template-factory │ 419 B │ 411 B ║
║ test │ 923 B │ 627 B ║
-║ utils │ 4.11 KB │ 3.6 KB ║
+║ utils │ 4.42 KB │ 3.76 KB ║
║ version │ 55 B │ 131 B ║
╚══════════════════════╧═══════════╧═══════════╝
╔═════════════════╤══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼──────────┼──────────╢
-║ Total │ 38.6 KB │ 21.94 KB ║
+║ Total │ 57.97 KB │ 32.67 KB ║
╟─────────────────┼──────────┼──────────╢
-║ destroyable │ 2.77 KB │ 1.39 KB ║
-║ encoder │ 81 B │ 171 B ║
+║ destroyable │ 4.66 KB │ 2.29 KB ║
+║ encoder │ 740 B │ 791 B ║
║ env │ 38 B │ 87 B ║
-║ global-context │ 886 B │ 545 B ║
-║ manager │ 977 B │ 608 B ║
-║ node │ 175 B │ 260 B ║
-║ opcode-compiler │ 1.11 KB │ 894 B ║
+║ global-context │ 2.23 KB │ 1.22 KB ║
+║ manager │ 6.5 KB │ 3.19 KB ║
+║ node │ 1.04 KB │ 842 B ║
+║ opcode-compiler │ 1.11 KB │ 904 B ║
║ owner │ 159 B │ 202 B ║
-║ program │ 252 B │ 301 B ║
-║ reference │ 548 B │ 531 B ║
-║ runtime │ 10.32 KB │ 5.32 KB ║
-║ tracking │ 1.34 KB │ 1.16 KB ║
-║ util │ 1.94 KB │ 1.68 KB ║
-║ validator │ 15.75 KB │ 6.96 KB ║
-║ vm │ 495 B │ 569 B ║
+║ program │ 367 B │ 323 B ║
+║ reference │ 3.51 KB │ 2.42 KB ║
+║ runtime │ 10.32 KB │ 5.22 KB ║
+║ tracking │ 2.11 KB │ 1.77 KB ║
+║ util │ 1.94 KB │ 1.71 KB ║
+║ validator │ 20.95 KB │ 9.85 KB ║
+║ vm │ 495 B │ 575 B ║
║ wire-format │ 1.84 KB │ 1.35 KB ║
╚═════════════════╧══════════╧══════════╝
Details
|
NullVoxPopuli
commented
Feb 24, 2026
Contributor
Author
Contributor
|
@NullVoxPopuli I've opened a new pull request, #21114, to work on those changes. Once the pull request is ready, I'll request review from you. |
NullVoxPopuli
commented
Feb 24, 2026
NullVoxPopuli
force-pushed
the
nvp/split-build
branch
from
1d15859 to
2359db6
Compare
NullVoxPopuli
force-pushed
the
nvp/split-build
branch
from
2359db6 to
e62085a
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apparently the perf script is trying to use the production bundle, so that kinda counts as tests
This PR depends on #21115 so that the esm / esm-template-compiler unification isn't weird / different from how it is on main