Update smoke tests app-template#21153
Open
github-actions[bot] wants to merge 48 commits intokg-run-smoke-tests-with-depsfrom
Open
Update smoke tests app-template#21153github-actions[bot] wants to merge 48 commits intokg-run-smoke-tests-with-depsfrom
github-actions[bot] wants to merge 48 commits intokg-run-smoke-tests-with-depsfrom
Conversation
d405e30 to
a3c21c0
Compare
Contributor
Author
📊 Package size report -0%↓
🤖 This report was automatically generated by pkg-size-action |
79b1408 to
99ade0d
Compare
…ruction to allow GC Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
…s elsewhere Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
6359d6c to
4df981a
Compare
Update dependency ember-cli to v6.11.0
…-workflow-4.x Update dependency ember-cli-deprecation-workflow to v4
d66c4d7 to
26b1747
Compare
Get @glimmer/syntax publishable again and get some smoke tests going for prettier
…NG_STATE to prevent GC retention When destroy(parent) triggers cascaded destruction of children, the child's scheduleDestroyed callback calls removeChildFromParent(child, parent). The previous guard `parentMeta.state === LIVE_STATE` prevented this from working when the parent was in DESTROYING_STATE, leaving stale strong references in parent_meta.children that prevent efficient GC of destroyed trees. Change the guard to `parentMeta.state !== DESTROYED_STATE` so that children properly remove themselves from a parent's children list even when the parent is in the process of being destroyed. The synchronous iterate(children, destroy) call has already completed by the time scheduleDestroyed callbacks run, so this modification is safe. Also add a test that verifies parent_meta.children is cleared after cascaded destruction. Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: kategengler <444218+kategengler@users.noreply.github.com>
- Update fixtures/component-test/app.gjs and addon.gjs to use parameterized <%= =%> templates for component, componentInvocation, and testDescription - Update component-test-test.js to expect .gjs files and pass testDescription - Update component-test.js to expect .gjs files in strict mode; add --loose flag to @ember/component test; update Foo::XFoo → XFoo componentInvocation - Update route-test.js: add strictRouteTemplate() helper; update all .hbs template expectations to .gjs with strictRouteTemplate(); update application.gjs removeSync; keep --loose and --route-authoring-format loose tests as-is (explicit loose mode) Root cause: ember-cli 6.11.0 now defaults to strict (GJS/template-tag) mode when creating new apps, so blueprints now generate .gjs files by default. Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
…st.js - Remove glimmerComponentContents and templateOnlyContents which are no longer referenced (components now use fixture() calls instead of inline strings) - Run prettier on route-test.js to fix formatting issues Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
When fixture() is called without options it returns a chai file object,
not a string. Calling .replace() on it throws a TypeError. Pass an empty
options object {} to force the helper to return a string so .replace()
works correctly for the class-name substitution.
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Since --strict is now the default, add tests that explicitly pass --loose to verify .js files are still generated correctly in each context: - in app: component-test foo --loose → foo-test.js (app.js fixture) - in app: component-test x-foo --unit --loose → x-foo-test.js (unit.js) - in addon: component-test foo --loose → foo-test.js (addon.js fixture) - in addon: component-test foo --unit --loose → foo-test.js (addon-unit.js) - in in-repo-addon: component-test foo ... --loose → foo-test.js (app.js) - in in-repo-addon: component-test x-foo ... --unit --loose → x-foo-test.js Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Lock file maintenance
…ia-PRing-tracerbench Reduce tracerbench hacks via PRing tracerbench updates
[BUGFIX] `current-when` with nested routes containing dynamic dynamic segments
…RectList, unused function, and avoid declaring global types
26b1747 to
4fd313a
Compare
(cherry picked from commit ca29776)
…etadata [BUGFIX] clear stale metadata references after destruction to allow GC
…karounds [CLEANUP] Remove old browser workarounds, targeting Ember 6.x
4fd313a to
199ad5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated the smoke-tests app-template using ember-cli latest.