Skip to content

Update smoke tests app-template#21153

Open
github-actions[bot] wants to merge 48 commits intokg-run-smoke-tests-with-depsfrom
smoke-tests/update-app-template
Open

Update smoke tests app-template#21153
github-actions[bot] wants to merge 48 commits intokg-run-smoke-tests-with-depsfrom
smoke-tests/update-app-template

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 3, 2026

Regenerated the smoke-tests app-template using ember-cli latest.

@kategengler kategengler force-pushed the smoke-tests/update-app-template branch 2 times, most recently from d405e30 to a3c21c0 Compare March 4, 2026 02:01
@kategengler kategengler changed the title Update ember-test-app template (ember-cli latest) Update smoke tests app-template Mar 4, 2026
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 4, 2026

📊 Package size report   -0%↓

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 17.3 MB / 3.2 MB -0%↓17.3 MB / -0.01%↓3.2 MB
Tarball size 3.9 MB -0%↓3.9 MB

🤖 This report was automatically generated by pkg-size-action

@kategengler kategengler force-pushed the smoke-tests/update-app-template branch 3 times, most recently from 79b1408 to 99ade0d Compare March 4, 2026 03:59
@kategengler kategengler changed the base branch from main to kg-run-smoke-tests-with-deps March 4, 2026 04:17
Copilot AI and others added 3 commits March 5, 2026 13:23
…ruction to allow GC

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
…s elsewhere

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
@kategengler kategengler force-pushed the kg-run-smoke-tests-with-deps branch 2 times, most recently from 6359d6c to 4df981a Compare March 5, 2026 19:56
@kategengler kategengler force-pushed the smoke-tests/update-app-template branch from d66c4d7 to 26b1747 Compare March 5, 2026 20:57
NullVoxPopuli and others added 12 commits March 5, 2026 16:13
Get @glimmer/syntax publishable again and get some smoke tests going for prettier
…NG_STATE to prevent GC retention

When destroy(parent) triggers cascaded destruction of children, the child's
scheduleDestroyed callback calls removeChildFromParent(child, parent). The
previous guard `parentMeta.state === LIVE_STATE` prevented this from working
when the parent was in DESTROYING_STATE, leaving stale strong references in
parent_meta.children that prevent efficient GC of destroyed trees.

Change the guard to `parentMeta.state !== DESTROYED_STATE` so that children
properly remove themselves from a parent's children list even when the parent
is in the process of being destroyed. The synchronous iterate(children, destroy)
call has already completed by the time scheduleDestroyed callbacks run, so
this modification is safe.

Also add a test that verifies parent_meta.children is cleared after cascaded
destruction.

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: kategengler <444218+kategengler@users.noreply.github.com>
- Update fixtures/component-test/app.gjs and addon.gjs to use parameterized
  <%= =%> templates for component, componentInvocation, and testDescription
- Update component-test-test.js to expect .gjs files and pass testDescription
- Update component-test.js to expect .gjs files in strict mode; add --loose
  flag to @ember/component test; update Foo::XFoo → XFoo componentInvocation
- Update route-test.js: add strictRouteTemplate() helper; update all .hbs
  template expectations to .gjs with strictRouteTemplate(); update
  application.gjs removeSync; keep --loose and --route-authoring-format loose
  tests as-is (explicit loose mode)

Root cause: ember-cli 6.11.0 now defaults to strict (GJS/template-tag) mode
when creating new apps, so blueprints now generate .gjs files by default.

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
…st.js

- Remove glimmerComponentContents and templateOnlyContents which are no
  longer referenced (components now use fixture() calls instead of inline
  strings)
- Run prettier on route-test.js to fix formatting issues

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
When fixture() is called without options it returns a chai file object,
not a string. Calling .replace() on it throws a TypeError. Pass an empty
options object {} to force the helper to return a string so .replace()
works correctly for the class-name substitution.

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Since --strict is now the default, add tests that explicitly pass --loose
to verify .js files are still generated correctly in each context:
- in app: component-test foo --loose → foo-test.js (app.js fixture)
- in app: component-test x-foo --unit --loose → x-foo-test.js (unit.js)
- in addon: component-test foo --loose → foo-test.js (addon.js fixture)
- in addon: component-test foo --unit --loose → foo-test.js (addon-unit.js)
- in in-repo-addon: component-test foo ... --loose → foo-test.js (app.js)
- in in-repo-addon: component-test x-foo ... --unit --loose → x-foo-test.js

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
NullVoxPopuli and others added 18 commits March 6, 2026 11:56
…ia-PRing-tracerbench

Reduce tracerbench hacks via PRing tracerbench updates
…gments

  When `current-when` is a string, pass no models to `isActiveForRoute()`
  since we only need route name matching, not model matching.
  Fixes #14615 and supersedes  #14787. Based on failing test by @amk221
 [BUGFIX] `current-when` with nested routes containing dynamic dynamic segments
…RectList, unused function, and avoid declaring global types
@kategengler kategengler force-pushed the smoke-tests/update-app-template branch from 26b1747 to 4fd313a Compare March 9, 2026 09:24
@kategengler kategengler force-pushed the smoke-tests/update-app-template branch from 4fd313a to 199ad5c Compare March 16, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants