Pull router_js into the Ember monorepo#21211
Open
mansona wants to merge 694 commits intoemberjs:mainfrom
Open
Conversation
bump dependencies
When calling replace on a replace, it should replace not update
The versions of prettier should be updated manually (to avoid churn in unrelated PRs).
Prevent context matching if the oldContext is null
fix `{{url-for 'posts' (hash queryParams=paramsHash)}}` use case
Fix a crash when (hash) helper is used to create queryParams object
Move to TypeScript
make delegate optional
[BREAKING] Router Abstract Base class
Calling recognize should not affect the transition.from query params for subsequent transitions
…yTypes Fix a type error when `exactOptionalPropertyTypes` is enabled
Fix followRedirects when source is async and destination is sync
# Conflicts: # pnpm-lock.yaml
mansona
force-pushed
the
router-js
branch
2 times, most recently
from
7602f70 to
41de687
Compare
mansona
force-pushed
the
router-js
branch
2 times, most recently
from
a011a1b to
df21fda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the Router RFC coming very soon we need to have router_js in the main monorepo. This PR does that work (with preserving history)
Still todo:
For anyone wanting to review this PR and not wanting to read all history from all of router_js then you can start at this commit and use the "Next commit" links at the top to go forward
Alternatively you can see the full diff with actual changes by looking at this link: mansona/ember.js@6f6c854...mansona:ember.js:router-js