Skip to content

Error when selecting should unselect #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Error when selecting should unselect #366

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e46fff0
Error when selecting should unselect
Jul 8, 2020
53f0d0d
Always unselect on any SELECT failure
Jul 8, 2020
639332e
Always unselect before progressing with SELECT
Jul 8, 2020
5730264
Revert to unnamed return values in Select.Handle
Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions server/cmd_auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,20 @@ type Select struct {

func (cmd *Select) Handle(conn Conn) error {
ctx := conn.Context()

// As per RFC1730#6.3.1,
// The SELECT command automatically deselects any
// currently selected mailbox before attempting the new selection.
// Consequently, if a mailbox is selected and a SELECT command that
// fails is attempted, no mailbox is selected.
// For example, some clients (e.g. Apple Mail) perform SELECT "" when the
// server doesn't announce the UNSELECT capability.
ctx.Mailbox = nil
ctx.MailboxReadOnly = false

if ctx.User == nil {
return ErrNotAuthenticated
}

mbox, err := ctx.User.GetMailbox(cmd.Mailbox)
if err != nil {
return err
Expand Down Expand Up @@ -149,7 +159,7 @@ func (cmd *List) Handle(conn Conn) error {
go (func() {
done <- conn.WriteResp(res)
// Make sure to drain the channel.
for _ = range ch {
for range ch {
}
})()

Expand Down