Skip to content

Conversation

eevdev
Copy link
Contributor

@eevdev eevdev commented Aug 14, 2023

Description

Make it possible to install any Listeners with Helm chart.

  • pick which of the default Listeners http and https to install
  • add custom Listeners
  • configure Listener spec

Related Issues

Resolves #5216

Testing

Manual testing with different Helm values.

Checklist

  • Does my change need to be backported to a previous release?

    • What backport versions were discussed with the Maintainers in the Issue?
  • I made sure to update CHANGELOG.md.

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • My change is adequately tested.

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

  • The changes in this PR have been reviewed for security concerns and adherence to security best practices.

@LanceEa
Copy link
Contributor

LanceEa commented Aug 29, 2023

@eevdev - Can you please rebase on master to fix the changelog? I will then get CI running.

@eevdev
Copy link
Contributor Author

eevdev commented Aug 30, 2023

@eevdev - Can you please rebase on master to fix the changelog? I will then get CI running.

Done! I made an assumption and put it under v8.9.0 in the changelog as it's still unreleased, but let me know if I should do something else.

Signed-off-by: Eivind Valderhaug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart: configure Listeners

2 participants