-
Notifications
You must be signed in to change notification settings - Fork 31
Temporarily disable arm build #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@yakutovicha This seems to work on Renku. Pausing/resuming the session as well. It seems that there're problems with multi-arch images, maybe something related to how K8s is set up? I added the annotations according to this page: https://docs.docker.com/build/exporters/image-registry/ |
|
Hi, I'm from the Renku team 👋 Great that you're able to get your image to work! However, I noticed it's rather large, it looks like over 11GB which means that sessions take a really long time to start. Is there any way you can reduce the image size? Are you adding data to the image or is it purely python packages? |
|
btw I believe to make multiarch images work you need to disable the |
|
Hey @rokroskar, thanks for reaching out!
The image doesn't work on my account, unfortunately. It remains like this and never proceeds further (not sure why 🤷 ) :
On my PC the image is 3.47 GB, see below: I feel a bit stuck here, any help would be greatly appreciated 🙏 |
|
I see this in our logs Your docker client might be reporting the compressed size? not sure. Unfortunately very large images can take a really long time to download and to start. I see torch installed - this can easily lead to very large images, especially if it is installed potentially multiple times. Could this be part of what is causing the large size? |
Hi @rokroskar! We're not even adding the content of the repository in the image. The base image is Is there any way to know about the image's actual size Renku is going to pull? |
Ah, well, PyTorch might easily be the responsible here. Honestly, I don't know a workaround other than trying to use another base image (or a combination?), where PT is already installed and maybe optimized |
|
I was more wondering if the different torch-enabled packages are maybe adding their own versions of cuda? That is what contributes to torch bloat. |
This image was built with repo2docker, we changed the approach recently. The image from this PR should be much smaller ( |
|
dive is a tool that can let you analyze docker images - specifically it can tell you how large is each layer in your image. Then you can use that information to optimize. It also has some tests/way to determine how "efficient" the image is, although I am not sure what metrics/heuristics it uses to determine that. |
|
@yakutovicha I am one of the renku developers. Can you share the project where you are trying to run the image that is failing? Is that possible? Or if not can you share the session launcher configuration you are using to launch that image? |
|
@olevski, thanks, yes sure. The project is https://renkulab.io/v2/projects/empa-scientific-it/empa-it-python-tutorial Just some heads up, I was wrong about failing. It took about 20 minutes to start for the first time, but then it was working. Regarding the image size, @edoardob90 will explore the options in a separate PR. Thanks a lot for the suggestions 🙏 |
|
Maybe another data point - I made a fork of this repo and moved the |
Ok if the session eventually starts then that is ok. I thought it was misconfigured and it was truly failing. What you describe is definitely the case of the image being really big. What @rokroskar suggested is a really viable option though. And it would save you some time in building and publishing the image. When you let Renku build the image we also store it in our own image repository which is much faster to access. Also I think ghcr and dockerhub start to throttle you after they see you keep pulling images. This cannot happen in the case where we build and host the image. Currently when you let Renku build the image for you we only support VSCodium. But in the new release (that is coming out in about a week from now) we will support also Jupyterlab. |
Only problem with using VS Code: some features for the interactive exercises rely on Jupyter+pytest, and that doesn't work properly when the notebooks are opened directly in VS Code (or Codium). |
|
superseded by #298 |


No description provided.