Skip to content

Use the glimmer syntax, because that's what we use. Not handlebars! #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NullVoxPopuli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use the glimmer syntax, because that's what we use. Not handlebars! #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/initializers/showdown-extensions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function initialize(/* application */) {

let preBlock = `<pre class="language-${language}"><code ${language ? `class="${language} language-${language}"` : ''}>${highlightedCodeBlock}</code></pre>`;

let autoExecuteLanguages = fieldGuideConfig.autoExecuteLanguages || ['html', 'handlebars', 'hbs'];
let autoExecuteLanguages = fieldGuideConfig.autoExecuteLanguages || ['html', 'handlebars', 'hbs', 'glimmer'];

let selfExecutingBlock = `<div class="self-executing-code-block">
<div class="example">
Expand Down
1 change: 1 addition & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ module.exports = {
'http',
'javascript',
'json',
'markup',
'markup-templating',
'ruby',
'scss'
Expand Down
7 changes: 7 additions & 0 deletions tests/dummy/app/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
/* global Prism */
import Application from '@ember/application';
import Resolver from 'ember-resolver';
import loadInitializers from 'ember-load-initializers';
import config from 'dummy/config/environment';

import { setup } from 'ember-prism';
Copy link
Author

@NullVoxPopuli NullVoxPopuli Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each consuming app will have to do this, unless there is a field-guide entrypoint we can have folks import and do this setup on behalf of people.


export default class App extends Application {
modulePrefix = config.modulePrefix;
podModulePrefix = config.podModulePrefix;
Resolver = Resolver;
}

loadInitializers(App, config.modulePrefix);
setup();

Prism.languages.hbs = Prism.languages.glimmer;
Copy link
Author

@NullVoxPopuli NullVoxPopuli Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handlebars is taken care of: https://github.com/shipshapecode/ember-prism/blob/main/addon/index.js#L4

Prism.languages.html = Prism.languages.glimmer;