Skip to content

Enable dup() test with legacy FS. NFC #23772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Enable dup() test with legacy FS. NFC #23772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13989,13 +13989,8 @@ def test_unistd_close_noderawfs(self):
self.emcc_args += ['--pre-js', 'pre.js']
self.do_run_in_out_file_test('unistd/close.c')

# WASMFS tests

# TODO: This test will only work with the new file system.
# Addresses this issue: https://github.com/emscripten-core/emscripten/issues/4017
# The new file system also correctly identifies errors that the JS file system missed.
def test_wasmfs_dup(self):
self.set_setting('WASMFS')
@also_with_wasmfs
def test_unistd_dup(self):
self.do_run_in_out_file_test('wasmfs/wasmfs_dup.c')

@also_with_wasmfs
Expand Down