Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Feb 26, 2025

This enabled wasmfs.test_unistd_dup to pass

@sbc100 sbc100 requested a review from kripken February 26, 2025 21:35
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right, and it enables the test to pass, but it makes WasmFS less capable than before with the new limit.

I guess the limit might be fine, as it's higher than Linux's?

@sbc100
Copy link
Collaborator Author

sbc100 commented Feb 26, 2025

We can always up the limit or make it configurable via getrlimit/setrlimit.

@sbc100
Copy link
Collaborator Author

sbc100 commented Feb 26, 2025

According to AI: "The default RLIMIT_NOFILE resource limit for userspace processes on Linux is 1024 (soft) and 4096 (hard). This limit specifies the maximum number of file descriptors that a process can open. "

This enabled wasmfs.test_unistd_dup to pass
@sbc100 sbc100 merged commit b1837cc into emscripten-core:main Feb 26, 2025
23 of 29 checks passed
@sbc100 sbc100 deleted the wasmfs_max_fd branch February 26, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants