Avoid double-reporting the filename in JS library errors/warnings #23787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
js_warnings_part2
branch
3 times, most recently
from
a440409 to
c5a9b62
Compare
kripken
reviewed
Feb 27, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Feb 28, 2025
System library paths are converted to absolute paths, both in link.py and in modules.mjs, but use JS libraries are left in their original form. Added a test to confirm that a user library can have the same name as as system library without issue. Split out from emscripten-core#23787
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Feb 28, 2025
System library paths are converted to absolute paths, both in link.py and in modules.mjs, but use JS libraries are left in their original form. Added a test to confirm that a user library can have the same name as as system library without issue. Split out from emscripten-core#23787
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Feb 28, 2025
System library paths are converted to absolute paths, both in link.py and in modules.mjs, but use JS libraries are left in their original form. Added a test to confirm that a user library can have the same name as as system library without issue. Split out from emscripten-core#23787
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Feb 28, 2025
System library paths are converted to absolute paths, both in link.py and in modules.mjs, but use JS libraries are left in their original form. Added a test to confirm that a user library can have the same name as as system library without issue. Split out from emscripten-core#23787
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Feb 28, 2025
System library paths are converted to absolute paths, both in link.py and in modules.mjs, but use JS libraries are left in their original form. Added a test to confirm that a user library can have the same name as as system library without issue. Split out from emscripten-core#23787
sbc100
force-pushed
the
js_warnings_part2
branch
2 times, most recently
from
437bad4 to
caae33c
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Feb 28, 2025
System library paths are converted to absolute paths, both in link.py and in modules.mjs, but use JS libraries are left in their original form. Added a test to confirm that a user library can have the same name as as system library without issue. Split out from emscripten-core#23787
sbc100
force-pushed
the
js_warnings_part2
branch
2 times, most recently
from
698fcc0 to
34d15bb
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 1, 2025
System library paths are converted to absolute paths, both in link.py and in modules.mjs, but use JS libraries are left in their original form. Added a test to confirm that a user library can have the same name as as system library without issue. Split out from emscripten-core#23787
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 1, 2025
System library paths are converted to absolute paths, both in link.py and in modules.mjs, but use JS libraries are left in their original form. Added a test to confirm that a user library can have the same name as as system library without issue. Split out from emscripten-core#23787
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 1, 2025
System library paths are converted to absolute paths, both in link.py and in modules.mjs, but use JS libraries are left in their original form. Added a test to confirm that a user library can have the same name as as system library without issue. Split out from emscripten-core#23787
sbc100
added a commit
that referenced
this pull request
Mar 1, 2025
System library paths are converted to absolute paths, both in link.py and in modules.mjs, but use JS libraries are left in their original form. Added a test to confirm that a user library can have the same name as as system library without issue. Split out from #23787
As part of this I also avoid converting JS libraries path to absolute paths where possible. This means that errors and warnings show the actual pathname passed by the users, and not some absolute path. This makes writing tests for the double-reporting issue easier, and makes the errors/warnings easier to read (IMHO).
sbc100
force-pushed
the
js_warnings_part2
branch
from
34d15bb to
84c8eb4
Compare
|
OK, this PR is now much simpler since #23798 landed separately. |
dschuff
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.