Fix FindOpenGL.cmake when included more than once #24034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Apr 2, 2025
| add_executable(test_prog test.c) | ||
|
|
||
| find_package(OpenGL REQUIRED) | ||
| find_package(OpenGL REQUIRED) |
There was a problem hiding this comment.
Why do we need these duplicate lines here and below?
There was a problem hiding this comment.
Just to test that its safe to find the package more than once.
There was a problem hiding this comment.
Oh, maybe add a comment then. Otherwise the test code looks like it might be a copy-paste error I think.
kripken
approved these changes
Apr 2, 2025
| add_executable(test_prog test.c) | ||
|
|
||
| find_package(OpenGL REQUIRED) | ||
| find_package(OpenGL REQUIRED) |
There was a problem hiding this comment.
Oh, maybe add a comment then. Otherwise the test code looks like it might be a copy-paste error I think.
Fixes a bug introduced in emscripten-core#23705.
kripken
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #23705.