[jspi] Require async js functions when used with __async decorator. #25480
Conversation
|
|
||
| import assert from 'node:assert'; | ||
| import * as fs from 'node:fs/promises'; | ||
| import { isAsyncFunction } from 'node:util/types'; |
There was a problem hiding this comment.
Oh.. interesting. TIL about this.
| emscripten_sleep__deps: ['$safeSetTimeout'], | ||
| emscripten_sleep__async: true, | ||
| emscripten_sleep: (ms) => Asyncify.handleSleep((wakeUp) => safeSetTimeout(wakeUp, ms)), | ||
| emscripten_sleep: async (ms) => Asyncify.handleSleep((wakeUp) => safeSetTimeout(wakeUp, ms)), |
There was a problem hiding this comment.
What does flagging this async gain here? (it costs code size)
I understand the rationale for async is that one can await for the return value, but for functions that return void, isn't the async keyword dead code?
Though Asyncify and JSPI build modes itself do not need the functions to be flagged async do they? (in WebGPU JSPI support I went with this)
There was a problem hiding this comment.
It really doesn't add anything here, but consistency. We have a few spots where we auto modify the library js (e.g. memory 64). It's much easier in those wrapper functions to assume we're in a async function and emit await code (also the await code is usually shorter).
brendandahl
force-pushed
the
jspi-async-decorator
branch
from
516af5b to
f8b8c87
Compare
The `_emval_await` library function is marked `_emval_await__async: true`, but the js function is not async. With memory64 enabled we auto convert to bigint and look for the async keyword (which is missing) to apply the await before creating the BigInt. With my changes __async will require an async js function, which signals the function is used with JSPI and the appropriate awaits are then inserted.
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (1) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_hello_dylink_all.json: 843587 => 843592 [+5 bytes / +0.00%] Average change: +0.00% (+0.00% - +0.00%) ```
brendandahl
force-pushed
the
jspi-async-decorator
branch
from
f8b8c87 to
c8e1794
Compare
The
_emval_awaitlibrary function is marked_emval_await__async: true, but the js function is not async. With memory64 enabled we auto convert to bigint and look for the async keyword (which is missing) to apply the await before creating the BigInt. With my changes __async will require an async js function, which signals the function is used with JSPI and the appropriate awaits are then inserted.Fixes #25468