Flip some negated #if checks. NFC

[sbc100]

This helps with readability IMHO since you don't need to do a double negative when considering the #else block.

[kripken]

OTOH, "not relocatable == normal", and it's nice to have the normal path first? Then reading the more complex relocatable one after is easier.

[sbc100]

This one has annoyed me for a while. Every time I read I feel like have to do mental work for some reason.

[kripken]

If the negation here is annoying, how about var ABSOLUTE = !RELOCATABLE or some better name for "simple, absolute-addressed single file with no linking involved" - ?

(Perhaps "linked file", "relocated file", "flat file" - maybe there is a good term?)

That would avoid the negation, and also let us keep having the simple code first in each such if-else.

[sbc100]

Actually in this case I like the if RELOCATABLE.

The code here is part of the undefined symbol handling. Its within a block and its already an error in most cases.

It reads like this:

if (is_undefined) {
   maybe_report_an_error();
   // Here we are continuing with the undefined symbol
   if (RELOCATABLE) {  // AKA dynamic linking
      create_a_dylink_stub();
   } else {
      create_an_abort_stub();
   } 
}

I think this is more logical that the other way around:

if (is_undefined) {
   maybe_report_an_error();
   // Here we are continuing with the undefined symbol
   if (!RELOCATABLE) {
      create_an_abort_stub();
   } else {
      create_a_dylink_stub();
   } 
}

[kripken]

Fair enough, I can live with this one. Reading the others again now.

[sbc100]

I just noticed the isStub = true; is repeated in both condition here too

[sbc100]

Ok to land?