Draft
Conversation
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
from
07ddd2b to
7015291
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Choose_BiQuad_Q
branch
from
ce46321 to
8ac3b2d
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
from
7015291 to
4a922e6
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Choose_BiQuad_Q
branch
from
8ac3b2d to
ac64520
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
from
4a922e6 to
64a1957
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Choose_BiQuad_Q
branch
from
ac64520 to
77d9aab
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
2 times, most recently
from
0c4ee8b to
3aab740
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Choose_BiQuad_Q
branch
from
77d9aab to
000931e
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
from
3aab740 to
e86e758
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Choose_BiQuad_Q
branch
from
000931e to
490fbd4
Compare
nerdCopter
force-pushed
the
emuflight-1.0.0-master
branch
2 times, most recently
from
fe70257 to
fe7710c
Compare
nerdCopter
force-pushed
the
20220329_cherry_pick_Choose_BiQuad_Q
branch
from
490fbd4 to
052c7e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows the ability to choose your q value for the biquad filter. Filters with a higher q will have a steeper cutoff at the cutoff freq, and a lower q has more of a roll off. The lower q will lead to less ringing and more linear changes in phase delay and frequency. Higher q will have your phase delay more abrupt. A q of 71 (will turn into 0.71) approximates butterworth filter response, and a q of 57 (0.57) will approximate bessel filter response.