Skip to content

fix: resolve async stream resource leak on timeout #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve async stream resource leak on timeout #3700

wants to merge 1 commit into from
+33 −4

Conversation

@joao-faria-dev
Copy link

@joao-faria-dev joao-faria-dev commented Oct 29, 2025 •
edited
Loading

Hello everyone! I got an error when running the tests and saw that there was already a issue related to this (#3686)

Summary

Fix async stream resource leak that caused ResourceWarning in Trio, basically replacing ByteStream.aiter() async generator with a iterator that can be properly closed via aclose()

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joao-faria-dev