Skip to content

Conversation

danfinlay
Copy link

Added an explanation to first time repository setup that would've saved me a little research as a non-lerna-native.

Added an explanation to first time repository setup that would've saved me a little research as a non-lerna-native.

## Contributing

This repository uses lerna as a monorepo, to allow the included packages to depend on each other.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the cross-package linking is a yarn feature and the tooling for publishing is facilitated by lerna, but the boundary is vague in my mind.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe link CONTRIBUTING.md.


## Contributing

This repository uses lerna as a monorepo, to allow the included packages to depend on each other.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe link CONTRIBUTING.md.

Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to a conventional commit, like:

docs: Add getting started instructions for contributors to README

@kriskowal
Copy link
Member

Also, I’m sure it would have helped to have a call-out to https://www.conventionalcommits.org/en/v1.0.0/ in CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants