fix(ses): (assert-shim): No error redaction without lockdown #3005
+19
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2025
erights
approved these changes
Dec 15, 2025
Contributor
erights
left a comment
erights
left a comment
There was a problem hiding this comment.
LGTM.
Can we test this? If so, please add a test. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation to introduce a new
@endo/hardenpackage, toward #2983 decoupling harden from lockdown, it became evident that redacting errors without lockdown left a system in an undebuggable state, since lockdown is necessary to install an unredacter. This was an oversight easily fixed. The defaultassertintroduced by initialization ofsesshould not redact, andlockdownshould replace thisassertwith one that does redact along with its paired unredactingconsoleand platform hooks for unredacting uncaught errors and unhandled rejections.This is important because it will allow multiplexed tests to see the same exception messages before and after lockdown when using
ses-ava.Security Considerations
This relaxation pertains only to systems that run without lockdown and for which SES provides no security claims.
Scaling Considerations
None.
Documentation Considerations
None.
Testing Considerations
None.
Compatibility Considerations
None.
Upgrade Considerations
None.