Auto-generate C_lut.npy; basic .gitignore; progbar; fix title in cplot.py#18
Open
OverLordGoldDragon wants to merge 4 commits intoendolith:masterfrom
Open
Auto-generate C_lut.npy; basic .gitignore; progbar; fix title in cplot.py#18OverLordGoldDragon wants to merge 4 commits intoendolith:masterfrom
C_lut.npy; basic .gitignore; progbar; fix title in cplot.py#18OverLordGoldDragon wants to merge 4 commits intoendolith:masterfrom
Conversation
Author
|
Meanwhile for others: If ZIP manages 8.2 -> 6.6, proper compression should do great, but will add dependency. 8.2MB is really fine. |
Owner
|
Yeah I didn't know the best thing to do. See #10 also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8.1MB is certainly acceptable, and since it's required for the library to function, it should simply be included. Generation took an hour on my powerful CPU, that's the real problem.
#17