Add Context #142
Merged
Add Context #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdtanrikulu
requested changes
May 22, 2023
* Added descriptions, additional subgraph info and results to queries * initial import * add tests * Update ens-data-guide.md Update language for correction * correct spelling of authors name * Update ens-data-guide.md Fix typos * Update dns-registrar-guide.md I believe this space between `a` and the address is not accepted by the `DNSClaimChecker` * add gen docs, remove github links, update dir names * add clarifications, join/split, more examples, cleanup * check formatting * check formatting again * minor fixes * minor fixes again * Update ens-l2-offchain.md (#143) rename starkware to starknet, as starkware is not an L2 but a company. * add comment about strings/codepoints * expand emoji definition * update formatting * remove emoji arrow * minor fixes * return * Update ens-as-nft.md * adding dynamic metadata section * add storage location and removed event --------- Co-authored-by: PaulieB14 <[email protected]> Co-authored-by: Andrew Raffensperger <[email protected]> Co-authored-by: Nick Johnson <[email protected]> Co-authored-by: Matt Galligan <[email protected]> Co-authored-by: nftyslobo <[email protected]> Co-authored-by: MalfurionWhitehat <[email protected]> Co-authored-by: Peter Anyaogu <[email protected]> Co-authored-by: Adwit M <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
metadatafunction returns name, coinType, graphqlUrl, storageType, contextOffchainschema is moved from l2 scheme to l1 schemeOffchain.idis the address of the l1 resolver (no chain specific info so that non chain solutions can also put their info without having chain id / cointypeexpiryDateon l2 Domain schemaImplementations