Check consistency between 32- and 64-bit platforms #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 92.14% 92.24% +0.10%
==========================================
Files 45 46 +1
Lines 10667 10768 +101
==========================================
+ Hits 9829 9933 +104
+ Misses 838 835 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fjarri
force-pushed
the
platform-dependency
branch
from
71ed8fc to
7d7c75b
Compare
fjarri
force-pushed
the
platform-dependency
branch
from
7d7c75b to
4ec64df
Compare
Add some test vectors for `Uint::from_xof_reader()` Fix yaml error rustfmt Fix CI More platform independence tests Fix an error in test
fjarri
force-pushed
the
platform-dependency
branch
from
4ec64df to
77d2413
Compare
dvdplm
reviewed
Jun 9, 2025
Contributor
dvdplm
left a comment
dvdplm
left a comment
There was a problem hiding this comment.
I think the tests in rsa.rs and traits.rs both need a comment explaining where the numbers come from and why the tests are there in the first place.
LGTM otherwise (although: should we bump MSRV?)
| use super::FromXofReader; | ||
| use crate::tools::hashing::{Chain, Hasher}; | ||
|
|
||
| #[test] |
Contributor
There was a problem hiding this comment.
Suggested change
| #[test] | |
| // Test to ensure that random seeds work the same on 32 and 64 bit platforms | |
| #[test] |
…or something to that effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some differences are caused by
crypto-primes(see entropyxyz/crypto-primes#80) andcrypto-bigint(see RustCrypto/crypto-bigint#781)