feat: enable enterprise web search for gemini models #1526
Conversation
dosubot
bot
added
the
size:S
dosubot
bot
added
size:M
hustxiayang
force-pushed
the
gemini-search
branch
from
8f29ea8 to
c395cb0
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1526 +/- ##
==========================================
- Coverage 84.03% 84.01% -0.03%
==========================================
Files 141 141
Lines 13039 13047 +8
==========================================
+ Hits 10957 10961 +4
- Misses 1460 1463 +3
- Partials 622 623 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hustxiayang
force-pushed
the
gemini-search
branch
from
c395cb0 to
da9bdfe
Compare
|
/retest |
1 similar comment
|
/retest |
dosubot
bot
added
size:L
#1554) **Description** Some new features were introduced in gemini3: **1 thinking_level:** https://ai.google.dev/gemini-api/docs/gemini-3?thinking=low#thinking_level This is similar to reasoning_effort of openai, thus, unified them. **2 media_resolution** https://ai.google.dev/gemini-api/docs/gemini-3?thinking=low#media_resolution This is similar to detail in openai, thus, unified them. The difference is that openai does not provide a global config of media_resolution. Thus, added it as gcp specific, but still use detail to make the name consistent. **Some related PRs:** thinking_budget is in #1461 thinking_level and thinking_budget are both supported, but can not use them together. Other features under review: **1 web search:** #1526 **2 parse the thought summary:** #1521 --------- Signed-off-by: yxia216 <[email protected]> Signed-off-by: Alexa Griffith <[email protected]> Signed-off-by: Sukumar Gaonkar <[email protected]> Co-authored-by: Alexa Griffith <[email protected]> Co-authored-by: Sukumar Gaonkar <[email protected]> Co-authored-by: Ignasi Barrera <[email protected]>
|
This needs a documentation update: https://aigateway.envoyproxy.io/docs/capabilities/llm-integrations/vendor-specific-fields (could you also backfill the doc for other fields added recently that lack docs if any?) |
|
|
||
| // EnterpriseWebSearch controls whether to use Web Grounding for Enterprise | ||
| // https://docs.cloud.google.com/vertex-ai/generative-ai/docs/grounding/web-grounding-enterprise | ||
| EnterpriseWebSearch bool `json:"enterprise_search,omitzero"` |
There was a problem hiding this comment.
There is a list of supported tools, I think we should define a list here
https://github.com/googleapis/go-genai/blob/6a8184fcaf8bf15f0c566616a7b356560309be9b/types.go#L3934
There was a problem hiding this comment.
@yuzisun you mean this list: https://github.com/googleapis/go-genai/blob/6a8184fcaf8bf15f0c566616a7b356560309be9b/types.go#L1406? Do we have plans to support them?
There was a problem hiding this comment.
see how litellm supports the web search tool, I think we can extend the openai tool type?
https://docs.litellm.ai/docs/providers/vertex#enterprise-web-search
There was a problem hiding this comment.
const (
ToolTypeFunction ToolType = "function"
ToolTypeImageGeneration ToolType = "image_generation"
ToolTypeEnterpriseWebSearch = "enterprise_search"
)
type Tool struct {
Type ToolType `json:"type"`
Function *FunctionDefinition `json:"function,omitempty"`
}
hustxiayang
force-pushed
the
gemini-search
branch
from
23d2ea3 to
8df3860
Compare
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
Signed-off-by: yxia216 <[email protected]>
hustxiayang
force-pushed
the
gemini-search
branch
from
8df3860 to
a451f7d
Compare
@mathetake Thanks a lot for your comment! @yuzisun started a pr #1590, so I left a comment about recent changes under that pr. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
4 participants
Description
This is to enable feature
Web Grounding for Enterprise: https://docs.cloud.google.com/vertex-ai/generative-ai/docs/grounding/web-grounding-enterpriseRelated Issues/PRs (if applicable)
#1417