feat: add compressor field to configure compression setting in BackendTrafficPolicy #6956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6956 +/- ##
==========================================
+ Coverage 70.96% 71.02% +0.05%
==========================================
Files 229 229
Lines 41012 41024 +12
==========================================
+ Hits 29106 29136 +30
+ Misses 10190 10174 -16
+ Partials 1716 1714 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sudiptob2
force-pushed
the
feat/implement-compressor-field
branch
from
c367bd8 to
f0f309c
Compare
sudiptob2
changed the title
arkodg
reviewed
Sep 24, 2025
| // +patchStrategy=merge | ||
| // | ||
| // +optional | ||
| Compressor []*Compression `json:"compressor,omitempty" patchMergeKey:"type" patchStrategy:"merge"` |
There was a problem hiding this comment.
can we rm the patchMergeKey, they are not needed here
sudiptob2
force-pushed
the
feat/implement-compressor-field
branch
from
ba27eea to
286ba06
Compare
sudiptob2
force-pushed
the
feat/implement-compressor-field
branch
from
286ba06 to
46265cc
Compare
sudiptob2
force-pushed
the
feat/implement-compressor-field
branch
2 times, most recently
from
4739514 to
1d3f7ac
Compare
…dTrafficPolicy Signed-off-by: sudipto baral <[email protected]>
…mpressor field and deprecate the old compression field Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
sudiptob2
force-pushed
the
feat/implement-compressor-field
branch
from
1d3f7ac to
86678f2
Compare
Removed unnecessary patchMergeKey and patchStrategy from Compressor field. Signed-off-by: Rudrakh Panigrahi <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>
rudrakhp
approved these changes
Oct 18, 2025
|
/retest |
aburan28
pushed a commit
to aburan28/gateway
that referenced
this pull request
Oct 18, 2025
…dTrafficPolicy (envoyproxy#6956) * feat: add compressor field to configure compression setting in BackendTrafficPolicy Signed-off-by: sudipto baral <[email protected]> * docs: update response compression documentation to reflect the new compressor field and deprecate the old compression field Signed-off-by: sudipto baral <[email protected]> * test: update translator tests outputs Signed-off-by: sudipto baral <[email protected]> * test: re-generate outputs Signed-off-by: sudipto baral <[email protected]> * test: go mod tidy Signed-off-by: sudipto baral <[email protected]> * remove patchMerge from Compressor field definition Removed unnecessary patchMergeKey and patchStrategy from Compressor field. Signed-off-by: Rudrakh Panigrahi <[email protected]> * revert patchMergeKey changes Signed-off-by: Rudrakh Panigrahi <[email protected]> --------- Signed-off-by: sudipto baral <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> Co-authored-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: Adam Buran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6924
This PR implements a new
Compressorfield and deprecates the existingCompressionfield.