chore: add more to for debugging kube test flake #7083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
force-pushed
the
kube-test-flake
branch
from
9af6990 to
d408611
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7083 +/- ##
=======================================
Coverage 71.09% 71.09%
=======================================
Files 228 228
Lines 40602 40602
=======================================
Hits 28867 28867
+ Misses 10044 10042 -2
- Partials 1691 1693 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
changed the title
zirain
force-pushed
the
kube-test-flake
branch
3 times, most recently
from
1e41132 to
84b84e6
Compare
arkodg
reviewed
Oct 1, 2025
| } | ||
|
|
||
| // Scheduled=True condition not found. | ||
| t.Logf("Accepted=True condition not found in Gateway %s/%s conditions: %+v", gw.Namespace, gw.Name, gw.Status.Conditions) |
There was a problem hiding this comment.
but the test is for Scheduled
There was a problem hiding this comment.
for _, cond := range gw.Status.Conditions {
fmt.Printf("Condition: %v\n", cond)
if cond.Type == string(gwapiv1.GatewayConditionAccepted) && cond.Status == metav1.ConditionTrue {
return true
}
}
Was the previous comment accurate?
There was a problem hiding this comment.
it was broken before :( , can we make this Scheduled ?
There was a problem hiding this comment.
Actually, Scheduled is deprecated.
// Deprecated: use "Accepted" instead.
GatewayConditionScheduled GatewayConditionType = "Scheduled"
arkodg
reviewed
Oct 1, 2025
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
kube-test-flake
branch
from
84b84e6 to
2965b9a
Compare
zirain
force-pushed
the
kube-test-flake
branch
from
d33b825 to
52a1de0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve the log output