Skip to content

Conversation

zirain
Copy link
Member

@zirain zirain commented Sep 29, 2025

xref: #7042

Key changes:

  • move the use v1 struct as much as possible
  • TLSRoute now use v1alpha3 as storage version
  • Skip BackendTLSPolicy conformance test

@zirain zirain requested a review from a team as a code owner September 29, 2025 04:17
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
@zirain zirain changed the title chore: bump Gateway API to v1.4.0-rc.1 chore: bump Gateway API to v1.4.0-rc.2 Sep 30, 2025
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 71.62791% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.06%. Comparing base (29219cf) to head (57e2606).

Files with missing lines Patch % Lines
internal/gatewayapi/conformance/suite.go 0.00% 18 Missing ⚠️
internal/provider/kubernetes/status.go 0.00% 7 Missing and 6 partials ⚠️
internal/provider/kubernetes/indexers.go 30.00% 2 Missing and 5 partials ⚠️
internal/provider/kubernetes/controller.go 66.66% 4 Missing and 2 partials ⚠️
internal/provider/kubernetes/status_updater.go 0.00% 6 Missing ⚠️
internal/cmd/egctl/status.go 0.00% 2 Missing ⚠️
internal/gatewayapi/backendtrafficpolicy.go 71.42% 2 Missing ⚠️
internal/gatewayapi/envoyextensionpolicy.go 60.00% 2 Missing ⚠️
internal/gatewayapi/runner/runner.go 0.00% 2 Missing ⚠️
internal/gatewayapi/securitypolicy.go 80.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7090      +/-   ##
==========================================
+ Coverage   71.03%   71.06%   +0.02%     
==========================================
  Files         228      228              
  Lines       40602    40622      +20     
==========================================
+ Hits        28843    28867      +24     
- Misses      10062    10064       +2     
+ Partials     1697     1691       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

zirain added 3 commits October 2, 2025 01:46
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
@zirain zirain changed the title chore: bump Gateway API to v1.4.0-rc.2 feat: bump Gateway API to v1.4.0-rc.2 Oct 2, 2025
zirain added 2 commits October 2, 2025 17:23
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
@arkodg
Copy link
Contributor

arkodg commented Oct 3, 2025

thanks for working on this @zirain, with this change can users still input v1alpha2 TLSRoute and v1alpha3 BackendTLSPolicy resources in standalone mode as well as the default k8s mode ?

@zirain
Copy link
Member Author

zirain commented Oct 4, 2025

thanks for working on this @zirain, with this change can users still input v1alpha2 TLSRoute and v1alpha3 BackendTLSPolicy resources in standalone mode as well as the default k8s mode ?

I do belive it should

@zirain
Copy link
Member Author

zirain commented Oct 4, 2025

let me spilit the apiserver upgrade changed out to make this PR smaller.

@zirain zirain changed the title feat: bump Gateway API to v1.4.0-rc.2 feat: bump Gateway API to v1.4.0 Oct 7, 2025
Signed-off-by: zirain <[email protected]>
name: backend-tls-ca
namespace: gateway-conformance-infra
---
# keep this v1alpha3 to verify EG worked for both v1alpha3 and v1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @arkodg

@zirain
Copy link
Member Author

zirain commented Oct 7, 2025

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants