chore: improve validateClusterStatName #7440
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
force-pushed
the
improv-validateClusterStatName
branch
2 times, most recently
from
a4868ee to
a382dd4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7440 +/- ##
==========================================
- Coverage 72.42% 72.40% -0.02%
==========================================
Files 232 232
Lines 34307 34297 -10
==========================================
- Hits 24847 24833 -14
- Misses 7684 7686 +2
- Partials 1776 1778 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Nov 21, 2025
zirain
force-pushed
the
improv-validateClusterStatName
branch
2 times, most recently
from
59dc4b0 to
6cb7da3
Compare
sudiptob2
reviewed
Nov 25, 2025
Member
sudiptob2
left a comment
sudiptob2
left a comment
There was a problem hiding this comment.
Should this be invalid ? %ROUTE_NAME%/%. Currently, this is treated as valid.
Member
Author
what is this used for? |
Member
I see, not used just tried with this random string. I guess it's not needed. |
zirain
force-pushed
the
improv-validateClusterStatName
branch
2 times, most recently
from
0fbcc7f to
66cc0da
Compare
zhaohuabing
reviewed
Dec 4, 2025
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
improv-validateClusterStatName
branch
from
66cc0da to
f52b60b
Compare
Member
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve validateClusterStatName function,
%ROUTE_NAMEis invalid.