#9343 - Refactor: Resolve bunch of sonar problems 2#9403
Merged
rrodionov91 merged 11 commits intomasterfrom Mar 19, 2026
Merged
#9343 - Refactor: Resolve bunch of sonar problems 2#9403rrodionov91 merged 11 commits intomasterfrom
rrodionov91 merged 11 commits intomasterfrom
Conversation
rrodionov91
approved these changes
Mar 18, 2026
svvald
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
SonarQube Violation Fixes — Pull Request Description
Summary
This PR fixes 5 SonarQube rule violations across 33 files to improve code quality and type safety.
private staticorreadonlyexport let→export constreadonlyto operation classesTotal: 33 files updated. No functional changes; behavior preserved.
How did you fix the issue?
_instanceprivate inSequenceEventDelegationManager; addedreadonlyto ReactcontextTypeinSave.tsx.case Chem+default,case 'arrow'+case 'plus') to remove redundancy.export let editorEventswithexport const editorEventsand inline initialization;resetEditorEvents()now mutates in place.readonlyto constructor-only fields in 20 operation classes underpackages/ketcher-core/src/application/editor/operations/.whileconditions and arrow-function returns into separate statements.Check list
#1234 – issue name