Fix DPI scaling for hardcoded plot sizes in demo #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The demo used hardcoded pixel values for several plots which didn't scale with DPI, causing them to appear too small on high-DPI displays. Following ImGui's convention, this commit replaces hardcoded pixel values with ImGui::GetTextLineHeight() multiplied by appropriate factors. This ensures plots scale correctly with font size and DPI settings. Affected plots: - PolitiFact: Who Lies More? (400px -> 25*TextLineHeight) - Pie charts (250x250px -> 16*TextLineHeight square) - Heatmaps (225x225px -> 14*TextLineHeight square) - Scrolling/Rolling plots (150px -> 10*TextLineHeight) - DragRects/DragPoints plots (150px -> 10*TextLineHeight) - Drag and Drop plots (195px -> 13*TextLineHeight) This follows the same pattern used throughout ImGui's demo code for ensuring DPI-aware sizing.
Author
|
Before: After: |
brenocq
added
type:fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo used hardcoded pixel values for several plots which didn't scale with DPI, causing them to appear too small on high-DPI displays.
Following ImGui's convention, this commit replaces hardcoded pixel values with ImGui::GetTextLineHeight() multiplied by appropriate factors. This ensures plots scale correctly with font size and DPI settings.
Affected plots:
This follows the same pattern used throughout ImGui's demo code for ensuring DPI-aware sizing.