Skip to content

Conversation

@sankalpgambhir
Copy link
Member

@sankalpgambhir sankalpgambhir commented Jan 17, 2025

Adds a Mill build (new build for Mill > 0.12). Not replacing the sbt build yet. Intended to try it out and see what we lose or gain.

Adds a config for cross building Lisa for JVM and JS (though I have not yet tested exporting and using it from ScalaJS further yet).

> mill "lisa.js[3.5.2].assembly"
> mill "lisa.jvm[3.5.2].assembly"

(zsh at least does not like when you write [...] without quotes)

The other packages remain the same. Example:

> mill lisa-utils.compile

Would be good to rename these to remove the lisa- part at some point, but not necessary atm.

Also fixes a couple other minor warnings etc with the build.

@sankalpgambhir
Copy link
Member Author

sankalpgambhir commented Jan 17, 2025

That's definitely one of the worst ways to fail CI

Run sbt compile
/home/runner/work/_temp/31a981c6-9b00-4186-bed9-087720c7abf2.sh: line 1: sbt: command not found

Copy link
Collaborator

@SimonGuilloud SimonGuilloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants