Sort fields by offset in fields_to_type()#41
Open
cosama wants to merge 1 commit intoeric-wieser:masterfrom
Open
Sort fields by offset in fields_to_type()#41cosama wants to merge 1 commit intoeric-wieser:masterfrom
cosama wants to merge 1 commit intoeric-wieser:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40.
As discussed in above issue
fields_to_typedoes return incorrect data when fields are not sorted by offset. For example perception_plc does not require the fields to be sorted and can produce unsorted messages. While I strongly believe that the sorting should happen on message creation (how else would they be sorted in a meaningful way), it can not and probably should not be assumed to be done that way.This merge request would fix that.