-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add Grafana Pyroscope SDK support #18126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AskAlexSharov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have prometheus_client (which is push-style), not sure why we need +1 similar metrics client
|
Hi @AskAlexSharov . Pyroscope is used for profiling data collection so its additional data not exactly the same as Prometheus metrics. Also, this is something that is planned to be added to the https://github.com/NethermindEth/gas-benchmarks which would provide more data for finding out bottlenecks on the scenarios there. |
|
@cbermudez97 i see now... then i would approve this PR |
looks good to me |
|
@cbermudez97 could you push this to |
|
@taratorio Created #18174 using |
Summary
Add support for Grafana Pyroscope SDK in the Erigon client.
Changes
Usage