Skip to content

Conversation

@cbermudez97
Copy link
Contributor

Summary

Add support for Grafana Pyroscope SDK in the Erigon client.

Changes

  • Added flags to enable and configure the Pyroscope SDK Push mode.

Usage

erigon --pyroscope --pyroscope.server=http://localhost:4040 --pyroscope.tags=instance=my-instance

taratorio and others added 30 commits June 6, 2025 18:21
warning: probably works on linux only
Copy link
Collaborator

@AskAlexSharov AskAlexSharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have prometheus_client (which is push-style), not sure why we need +1 similar metrics client

@cbermudez97
Copy link
Contributor Author

Hi @AskAlexSharov . Pyroscope is used for profiling data collection so its additional data not exactly the same as Prometheus metrics. Also, this is something that is planned to be added to the https://github.com/NethermindEth/gas-benchmarks which would provide more data for finding out bottlenecks on the scenarios there.

@AskAlexSharov
Copy link
Collaborator

@cbermudez97 i see now... then i would approve this PR
@taratorio do you have anything against?

@taratorio
Copy link
Member

@cbermudez97 i see now... then i would approve this PR @taratorio do you have anything against?

looks good to me

@taratorio
Copy link
Member

@cbermudez97 could you push this to main branch instead of performance please? we can then sync latest main into the performance branch or cherry-pick the commit

@cbermudez97 cbermudez97 changed the base branch from performance to main December 4, 2025 14:33
@cbermudez97 cbermudez97 closed this Dec 4, 2025
@cbermudez97
Copy link
Contributor Author

@taratorio Created #18174 using main instead. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants