island: Fix get_ptr

[jschueller]

Closes #584

[jschueller]

hi @bluescarni , any thoughts on this ?

[darioizzo]

This is a good catch and in general we may improve idiomatically this in the future, but current GCC/Clang and runners all pass, that usually means the problematic instantiation path is no longer being hit in practice. @jschueller fix makes sense and is understandable, but

It is semantically noisier and suggests const-correctness is being bypassed for a reason, when it is not.
It can hide real constness bugs if this pattern spreads.
It reduces readability and maintainability without changing behavior for this case.

WIll not merge for now. But lets keep this in mind for the future.

[jschueller]

can you cherry-pick the doc fix though ?

[darioizzo]

I think its already fixed with the last main CI refresh?