Skip to content

Conversation

@Pixel998
Copy link
Contributor

@Pixel998 Pixel998 commented Sep 20, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR updates the minimatch package to the latest version

What changes did you make? (Give an overview)

  • Updated minimatch to v10.0.3
  • Switched to named imports for minimatch, in line with the updated API.
  • Removed the deprecated @types/minimatch package since minimatch now includes its own built-in TypeScript type definitions.

minimatch v10 requires Node.js v20 or higher, so marking this PR as draft until we drop Node.js v18.

Related Issues

Fixes #230
Fixes #66

Is there anything you'd like reviewers to focus on?

@mdjermanovic
Copy link
Member

Can we now remove allowWindowsEscape: true, option, since that behavior should be on by default in minimatch v10?

allowWindowsEscape: true,

@mdjermanovic
Copy link
Member

We should also update minimatch dependency in the eslint package:

https://github.com/eslint/eslint/blob/e1ac05e2fae779e738f85bd47dda1cc2b7099346/package.json#L139

@Pixel998
Copy link
Contributor Author

We should also update minimatch dependency in the eslint package

Yeah, it’s on my todo list — I’ll get to it today or tomorrow.

@nzakas nzakas removed this from Triage Oct 14, 2025
@aladdin-add
Copy link
Member

Yeah, it’s on my todo list — I’ll get to it today or tomorrow.

@Pixel998 I can take it(if you don't have time to look at it.)🙌

@Pixel998 Pixel998 changed the title chore: update minimatch feat!: update minimatch Oct 30, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Oct 30, 2025
@Pixel998
Copy link
Contributor Author

@aladdin-add Sorry for the late reply! It looks like there’s already a PR open for it.

@fasttime
Copy link
Member

When this is PR is merged, we should do a release and then update the @eslint/config-array dependency in the eslint repo in eslint/eslint#20246. I've updated the migration guide in that PR, so please check if my text makes sense, and feel free to change it.

@fasttime fasttime moved this from Needs Triage to Implementing in Triage Nov 16, 2025
fasttime
fasttime previously approved these changes Nov 16, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @mdjermanovic to review.

@fasttime fasttime marked this pull request as ready for review November 16, 2025 10:09
@mdjermanovic
Copy link
Member

I think we can remove allowWindowsEscape: true (#273 (comment)). It's a legacy, now-undocumented option (although not explicitly deprecated).

@Pixel998
Copy link
Contributor Author

Pixel998 commented Nov 16, 2025

@mdjermanovic I thought I had already made that change, but I must have missed it. Sorry about that!

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @fasttime to verify last changes.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Nov 16, 2025
@fasttime fasttime merged commit 8b92470 into eslint:main Nov 17, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Nov 17, 2025
@github-actions github-actions bot mentioned this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Upgrade minimatch in @eslint/config-array Update minimatch

4 participants