-
-
Notifications
You must be signed in to change notification settings - Fork 35
feat!: update minimatch #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can we now remove
|
|
We should also update minimatch dependency in the eslint package: https://github.com/eslint/eslint/blob/e1ac05e2fae779e738f85bd47dda1cc2b7099346/package.json#L139 |
Yeah, it’s on my todo list — I’ll get to it today or tomorrow. |
@Pixel998 I can take it(if you don't have time to look at it.)🙌 |
|
@aladdin-add Sorry for the late reply! It looks like there’s already a PR open for it. |
|
When this is PR is merged, we should do a release and then update the |
fasttime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Leaving open for @mdjermanovic to review.
|
I think we can remove |
|
@mdjermanovic I thought I had already made that change, but I must have missed it. Sorry about that! |
mdjermanovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Leaving open for @fasttime to verify last changes.
Prerequisites checklist
What is the purpose of this pull request?
This PR updates the
minimatchpackage to the latest versionWhat changes did you make? (Give an overview)
minimatchto v10.0.3minimatch, in line with the updated API.@types/minimatchpackage sinceminimatchnow includes its own built-in TypeScript type definitions.minimatchv10 requires Node.js v20 or higher, so marking this PR as draft until we drop Node.js v18.Related Issues
Fixes #230
Fixes #66
Is there anything you'd like reviewers to focus on?